Skip to content

Commit 8760758

Browse files
authored
Ledger.reset should reset containsRemoval status (#10338)
1 parent c072939 commit 8760758

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

internal-api/src/main/java/datadog/trace/api/TagMap.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -995,6 +995,7 @@ Entry findLastEntry(String tag) {
995995
public void reset() {
996996
Arrays.fill(this.entryChanges, null);
997997
this.nextPos = 0;
998+
this.containsRemovals = false;
998999
}
9991000

10001001
@Override

internal-api/src/test/java/datadog/trace/api/TagMapLedgerTest.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,8 @@ public void buildWithRemoves() {
201201
ledger.remove(key(i));
202202
}
203203

204+
assertTrue(ledger.containsRemovals());
205+
204206
TagMap map = ledger.build();
205207
for (int i = 0; i < SIZE; ++i) {
206208
if ((i % 2) == 0) {
@@ -209,6 +211,10 @@ public void buildWithRemoves() {
209211
assertEquals(value(i), map.getString(key(i)));
210212
}
211213
}
214+
215+
ledger.reset();
216+
217+
assertFalse(ledger.containsRemovals());
212218
}
213219

214220
@Test
@@ -218,6 +224,10 @@ public void smartRemoval_existingCase() {
218224
ledger.smartRemove("foo");
219225

220226
assertTrue(ledger.containsRemovals());
227+
228+
ledger.reset();
229+
230+
assertFalse(ledger.containsRemovals());
221231
}
222232

223233
@Test
@@ -226,6 +236,10 @@ public void smartRemoval_missingCase() {
226236
ledger.smartRemove("foo");
227237

228238
assertFalse(ledger.containsRemovals());
239+
240+
ledger.reset();
241+
242+
assertFalse(ledger.containsRemovals());
229243
}
230244

231245
@Test

0 commit comments

Comments
 (0)