performance: remove unneeded ToArray calls

Author: TimothyMakkison

Dapper.SqlBuilder/SqlBuilder.cs

@@ -48,10 +48,10 @@ public string ResolveClauses(DynamicParameters p)
                               .Union(new[]
                               {
                                   " ( " +
-                                  string.Join(" OR ", this.Where(a => a.IsInclusive).Select(c => c.Sql).ToArray()) +
+                                  string.Join(" OR ", this.Where(a => a.IsInclusive).Select(c => c.Sql)) +
                                   " ) "
-                              }).ToArray()) + _postfix
-                    : _prefix + string.Join(_joiner, this.Select(c => c.Sql).ToArray()) + _postfix;
+                              })) + _postfix
+                    : _prefix + string.Join(_joiner, this.Select(c => c.Sql)) + _postfix;
             }
         }
 

Dapper/DynamicParameters.cs

@@ -397,10 +397,10 @@ static void ThrowInvalidChain()
             }
             while (diving is not null);
 
-            var dynamicParamName = string.Concat(names.ToArray());
+            var dynamicParamName = string.Concat(names);
 
             // Before we get all emitty...
-            var lookup = string.Join("|", names.ToArray());
+            var lookup = string.Join("|", names);
 
             var cache = CachedOutputSetters<T>.Cache;
             var setter = (Action<object, DynamicParameters>?)cache[lookup];

Dapper/SqlMapper.cs

@@ -3498,7 +3498,7 @@ private static void GenerateDeserializerFromMap(Type type, DbDataReader reader,
                     var ctor = typeMap.FindConstructor(names, types);
                     if (ctor is null)
                     {
-                        string proposedTypes = "(" + string.Join(", ", types.Select((t, i) => t.FullName + " " + names[i]).ToArray()) + ")";
+                        string proposedTypes = "(" + string.Join(", ", types.Select((t, i) => t.FullName + " " + names[i])) + ")";
                         throw new InvalidOperationException($"A parameterless default constructor or one matching signature {proposedTypes} is required for {type.FullName} materialization");
                     }