You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I was working on my PR, I noticed that tests run directly on the data directories within the tests directory (Im sorry for the complicated sentence). Or the file path is passed directly as an argument.
Since some of the functionality modifies the document in-place, I am suggesting adding two fixtures/helper functions.
CloneFile
2. copy the contents of a file to a temporary file.
CloneDirectory
Copies the contents of a directory to a temporary directory
Changes the directory to that directory (monkeypatch it)
This would allow less boilerplate code on the tests, since it would automatically clean up any changes
that occur on the files (which might or might not be intended)
Use case ... if someone screws up coding and flips the "-write" parameter, it will not modify all the test files.
LMK what you think
The text was updated successfully, but these errors were encountered:
When I was working on my PR, I noticed that tests run directly on the data directories within the tests directory (Im sorry for the complicated sentence). Or the file path is passed directly as an argument.
Since some of the functionality modifies the document in-place, I am suggesting adding two fixtures/helper functions.
2. copy the contents of a file to a temporary file.
This would allow less boilerplate code on the tests, since it would automatically clean up any changes
that occur on the files (which might or might not be intended)
Use case ... if someone screws up coding and flips the "-write" parameter, it will not modify all the test files.
LMK what you think
The text was updated successfully, but these errors were encountered: