Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: playgameservices/play-games-plugin-for-unity
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: DanielGrave/play-games-plugin-for-unity
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Able to merge. These branches can be automatically merged.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 1, 2022

  1. Bug fix PlayGamesAchievement.cs

    Fixes:
    1- Method "LoadImage" always returning null;
    2- "hidden" property returning false when achievement had already been unlocked, this issue also made "LoadImage" return null values.
    DanielGrave authored Oct 1, 2022
    Copy the full SHA
    b722ce1 View commit details
Showing with 4 additions and 2 deletions.
  1. +4 −2 ...lic/GooglePlayGames/com.google.play.games/Runtime/Scripts/ISocialPlatform/PlayGamesAchievement.cs
Original file line number Diff line number Diff line change
@@ -89,7 +89,7 @@ internal PlayGamesAchievement(Achievement ach) : this()
}

this.mCompleted = ach.IsUnlocked;
this.mHidden = !ach.IsRevealed;
this.mHidden = !ach.IsRevealed && !ach.IsUnlocked;
this.mLastModifiedTime = ach.LastModifiedTime;
this.mTitle = ach.Name;
this.mDescription = ach.Description;
@@ -135,8 +135,10 @@ private Texture2D LoadImage()
{
#if UNITY_2017_1_OR_NEWER
mImageFetcher = UnityWebRequestTexture.GetTexture(url);
mImageFetcher.SendWebRequest();
#else
mImageFetcher = new WWW(url);
mImageFetcher.Send();
#endif
mImage = null;
}
@@ -283,4 +285,4 @@ public int points
}
}
}
#endif
#endif