Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with peer dependencies found #76

Open
vhscom opened this issue Mar 8, 2022 · 3 comments
Open

Issues with peer dependencies found #76

vhscom opened this issue Mar 8, 2022 · 3 comments

Comments

@vhscom
Copy link
Contributor

vhscom commented Mar 8, 2022

Dependents using this library face warnings which are erroneous in the context of a development workflow. Here's an example of the warnings generated (outlined with box):

Screen Shot 2022-03-08 at 10 45 18 AM

I believe this can be addressed by adding peerDependenciesMeta and setting "optional": true. Tried peerDependenciesMeta with some success but it's not a complete solution. See note here for investigation.

@ar4hc
Copy link

ar4hc commented Mar 21, 2022

adding build-esm breaks my svlete-kit, getting strange errors of imports not found, at least in dev...
Without it runs fine.

vhscom added a commit to vhscom/sk-auth that referenced this issue Mar 21, 2022
@mavdotj
Copy link

mavdotj commented Mar 21, 2022

I get errors like this with npm when installing nightwind with sveltekit

@vhscom vhscom closed this as completed May 19, 2022
@vhscom vhscom reopened this May 19, 2022
@vhscom
Copy link
Contributor Author

vhscom commented May 19, 2022

Oops. Closed in error. Updated OP to add a note on how to squelch the warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants