grace period for Midnight Aberration crumbling. Implements #603

Author: DaFuqs

src/main/java/de/dafuqs/spectrum/items/MidnightAberrationItem.java

@@ -4,8 +4,10 @@
 import de.dafuqs.spectrum.helpers.*;
 import de.dafuqs.spectrum.items.conditional.*;
 import de.dafuqs.spectrum.registries.*;
+import net.fabricmc.fabric.api.item.v1.*;
 import net.minecraft.client.item.*;
 import net.minecraft.entity.*;
+import net.minecraft.entity.player.*;
 import net.minecraft.item.*;
 import net.minecraft.nbt.*;
 import net.minecraft.server.network.*;
@@ -17,11 +19,16 @@
 
 import java.util.*;
 
-public class MidnightAberrationItem extends CloakedItem {
+public class MidnightAberrationItem extends CloakedItem implements FabricItem {
 
 	private static final Identifier MIDNIGHT_ABERRATION_CRUMBLING_ADVANCEMENT_ID = SpectrumCommon.locate("midgame/crumble_midnight_aberration");
 	private static final String MIDNIGHT_ABERRATION_CRUMBLING_ADVANCEMENT_CRITERION = "have_midnight_aberration_crumble";
 
+	// Aberrations crumble in the player's inventory (or any inventory that ticks)
+	// but only after a short grace period, to give them a chance to actually look at it / use it
+	private static final int CRUMBLING_GRACE_PERIOD_TICKS = 40;
+	private static final String FIRST_INVENTORY_TICK_NBT = "first_inventory_tick";
+	
 	public MidnightAberrationItem(Settings settings, Identifier cloakAdvancementIdentifier, Item cloakItem) {
 		super(settings, cloakAdvancementIdentifier, cloakItem);
 	}
@@ -36,6 +43,16 @@ public void inventoryTick(ItemStack stack, World world, Entity entity, int slot,
 				return;
 			}
 
+			NbtCompound nbtCompound = stack.getOrCreateNbt();
+			if (!nbtCompound.contains(FIRST_INVENTORY_TICK_NBT)) {
+				nbtCompound.putLong(FIRST_INVENTORY_TICK_NBT, world.getTime());
+				return;
+			}
+			long firstInventoryTick = nbtCompound.getLong(FIRST_INVENTORY_TICK_NBT);
+			if (world.getTime() < firstInventoryTick + CRUMBLING_GRACE_PERIOD_TICKS) {
+				return;
+			}
+			
 			// check if it's a real stack in the player's inventory or just a proxy item (like a Bottomless Bundle)
 			if (world.random.nextFloat() < 0.2F) {
 				stack.decrement(1);
@@ -57,6 +74,25 @@ public void appendTooltip(ItemStack stack, @Nullable World world, List<Text> too
 		}
 	}
 
+	@Override
+	public boolean allowNbtUpdateAnimation(PlayerEntity player, Hand hand, ItemStack oldStack, ItemStack newStack) {
+		// do not play the hand update animation when it starts crumbling
+		NbtCompound oldNbt = oldStack.getNbt();
+		NbtCompound newNbt = newStack.getNbt();
+		
+		if (newNbt == null) {
+			return super.allowNbtUpdateAnimation(player, hand, oldStack, newStack);
+		}
+		if (oldNbt != null && oldNbt.contains(FIRST_INVENTORY_TICK_NBT)) {
+			return super.allowNbtUpdateAnimation(player, hand, oldStack, newStack);
+		}
+		if (!newNbt.contains(FIRST_INVENTORY_TICK_NBT)) {
+			return super.allowNbtUpdateAnimation(player, hand, oldStack, newStack);
+		}
+		
+		return false;
+	}
+	
 	public ItemStack getStableStack() {
 		ItemStack stack = getDefaultStack();
 		NbtCompound compound = stack.getOrCreateNbt();