From cd56d4d636b7e965e84cb23bd1ecbba33c444b90 Mon Sep 17 00:00:00 2001 From: Robin Jarry Date: Mon, 20 Oct 2025 16:24:58 +0200 Subject: [PATCH] smoke: fix running grout in a separate terminal When grout is started manually in a separate terminal, pgrep -g0 grout returns nothing and exits with an error status. Indeed, there is no grout process started as a child of the shell script. Only check for the PID if grout was started by the script. Fixes: 6a7e9a4bffa2 ("smoke: print stack traces on crashes") Signed-off-by: Robin Jarry --- smoke/_init.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/smoke/_init.sh b/smoke/_init.sh index ebe170ff5..2e18227d4 100644 --- a/smoke/_init.sh +++ b/smoke/_init.sh @@ -140,7 +140,9 @@ if [ "$run_grout" = true ]; then taskset -c 0,1 grout -tvvx $grout_extra_options & fi socat FILE:/dev/null UNIX-CONNECT:$GROUT_SOCK_PATH,retry=10 -grout_pid=$(pgrep -g0 grout) +if [ "$run_grout" = true ]; then + grout_pid=$(pgrep -g0 grout) +fi case "$(basename $0)" in config_test.sh|graph_svg_test.sh)