Don't duplicate update strategy class name in enum values

Author: nickygerritsen

webapp/src/Service/DOMJudgeService.php

@@ -1749,7 +1749,7 @@ public function cacherCheckNewVersion(ItemInterface $item): array|false {
      * Returns either the next strictly higher version or false when nothing is found/requested.
      */
     public function checkNewVersion(): string|false {
-        if ($this->config->get('check_new_version', false) === UpdateStrategy::Strategy_none) {
+        if ($this->config->get('check_new_version', false) === UpdateStrategy::NONE) {
             return false;
         }
         // The local version is something like "x.y.z / commit hash", e.g. "8.4.0DEV/4e25adb13" for development
@@ -1775,7 +1775,7 @@ public function checkNewVersion(): string|false {
 
         preg_match("/\d.\d.\d/", $this->domjudgeVersion, $matches);
         $extractedLocalVersionString = $matches[0];
-        if ($this->config->get('check_new_version', false) === UpdateStrategy::Strategy_incremental) {
+        if ($this->config->get('check_new_version', false) === UpdateStrategy::INCREMENTAL) {
             /* Steer towards the nearest highest patch release first
              * So the expected path would be:
              * DJ6.0.0 -> DJ6.0.6 -> DJ6.6.0 -> DJ9.1.2 instead of
@@ -1801,7 +1801,7 @@ public function checkNewVersion(): string|false {
                     }
                 }
             }
-        } elseif ($this->config->get('check_new_version', false) === UpdateStrategy::Strategy_major_release) {
+        } elseif ($this->config->get('check_new_version', false) === UpdateStrategy::MAJOR_RELEASE) {
             /* Steer towards the latest version directly
              * So the expected path would be:
              * DJ6.0.0 -> DJ9.1.2

webapp/src/Utils/UpdateStrategy.php

@@ -4,16 +4,16 @@
 
 enum UpdateStrategy: string
 {
-    case Strategy_incremental = 'incremental';
-    case Strategy_major_release = 'major';
-    case Strategy_none = 'none';
+    case INCREMENTAL = 'incremental';
+    case MAJOR_RELEASE = 'major';
+    case NONE = 'none';
 
     public function getConfigDescription(): string
     {
         return match ($this) {
-            self::Strategy_incremental => 'Report on next patch releases, favoring reliability over features',
-            self::Strategy_major_release => 'Report on newest Major/minor releases, favoring being close to the version maintainers run',
-            self::Strategy_none => 'Do not report on any new versions',
+            self::INCREMENTAL => 'Report on next patch releases, favoring reliability over features',
+            self::MAJOR_RELEASE => 'Report on newest Major/minor releases, favoring being close to the version maintainers run',
+            self::NONE => 'Do not report on any new versions',
         };
     }
 }