Free memory on error

steven-bellock · jyao1 · commit af927261b32e · 2025-11-02T23:51:26.000+08:00
Fix #3334. Signed-off-by: Steven Bellock <sbellock@nvidia.com>
diff --git a/os_stub/spdm_device_secret_lib_sample/key_pair.c b/os_stub/spdm_device_secret_lib_sample/key_pair.c
@@ -471,6 +471,7 @@ bool libspdm_write_key_pair_info(
                 m_key_pair_info[key_pair_id - 1].assoc_cert_slot_mask =
                     desired_assoc_cert_slot_mask;
             } else {
+                free(cached_key_pair_info);
                 return false;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -471,6 +471,7 @@ bool libspdm_write_key_pair_info(`
`471`	`471`	`m_key_pair_info[key_pair_id - 1].assoc_cert_slot_mask =`
`472`	`472`	`desired_assoc_cert_slot_mask;`
`473`	`473`	`} else {`
	`474`	`+ free(cached_key_pair_info);`
`474`	`475`	`return false;`
`475`	`476`	`}`
`476`	`477`