fixed bug with updating identifiers. added rake task to v3 to fix fundref ids

Author: briri

app/controllers/concerns/org_selectable.rb

@@ -28,7 +28,7 @@
 #      \"name\":\"Portland State University (PDX)\",
 #      \"sort_name\":\"Portland State University\",
 #      \"ror\":\"https://ror.org/00yn2fy02\",
-#      \"fundref\":\"https://api.crossref.org/funders/100007083\"
+#      \"fundref\":\"https://doi.org/10.13039/100007083\"
 #    }
 #  }
 #

app/models/identifier.rb

@@ -133,8 +133,8 @@ def value_uniqueness_without_scheme
 
   # Ensure that the identifiable only has one identifier for the scheme
   def value_uniqueness_with_scheme
-    if Identifier.where(identifier_scheme: identifier_scheme,
-                        identifiable: identifiable).any?
+    if new_record? && Identifier.where(identifier_scheme: identifier_scheme,
+                                       identifiable: identifiable).any?
       errors.add(:identifier_scheme, _("already assigned a value"))
     end
   end

lib/tasks/upgrade.rake

@@ -832,7 +832,7 @@ namespace :upgrade do
 
       fundref = IdentifierScheme.find_or_initialize_by(name: "fundref")
       fundref.for_orgs = true
-      fundref.identifier_prefix = "https://api.crossref.org/funders/"
+      fundref.identifier_prefix = "https://doi.org/10.13039/"
       fundref.save
     end
 
@@ -1217,7 +1217,7 @@ namespace :upgrade do
     p "               'University of Somewhere' may match to 'Univerity of Somewhere - Medical Center'"
     p "            To correct any issues, please delete/insert/update the corresponding Identifier:"
     p "               delete from identifiers where identifiable_type = 'Org' and identifiable_id = [orgs.id];"
-    p "               insert into identifiers (identifiable_type, identifier_scheme_id, attrs, identifiable_id, value) values ('Org', [identifier_scheme_id], '{}', [orgs.id], 'https://api.crossref.org/funders/0000000000');"
+    p "               insert into identifiers (identifiable_type, identifier_scheme_id, attrs, identifiable_id, value) values ('Org', [identifier_scheme_id], '{}', [orgs.id], 'https://doi.org/10.13039/0000000000');"
     p "               update identifiers set `value` = 'https://ror.org/123456789' where identifiable_id = [orgs.id] and identifier_scheme_id = [identifier_scheme_id] and identifiable_type= 'Org';"
     p "---------------------------------------------------------------"
   end

lib/tasks/v3.rake

@@ -4,6 +4,7 @@ namespace :v3 do
   task upgrade_3_0_0: :environment do
     Rake::Task["v3:ensure_default_languages"].execute
     Rake::Task["v3:ensure_feedback_defaults"].execute
+    Rake::Task["v3:fix_funder_ids"].execute
   end
 
   # Set any records with a nil `language_id` to the default language
@@ -35,4 +36,24 @@ namespace :v3 do
     Org.where(feedback_email_msg: nil).update_all(feedback_email_msg: feedback_confirmation_default_message)
   end
 
+  # E.G. change 'https://api.crossref.org/funders/100000060' to 'https://doi.org/10.13039/100000060'
+  desc "Corrects the Crossref funder ids which were originally set to the URL instead of the DOI"
+  task fix_funder_ids: :environment do
+    scheme = IdentifierScheme.where(name: "fundref").first
+
+    incorrect_prefix = "https://api.crossref.org/funders/"
+    correct_prefix = "https://doi.org/10.13039/"
+
+    if scheme.present?
+      scheme.update(identifier_prefix: correct_prefix) unless scheme.identifier_prefix == correct_prefix
+      Identifier.where(identifier_scheme: scheme).each do |id|
+        next unless id.value.start_with?(incorrect_prefix)
+
+        id.update(value: id.value.gsub(incorrect_prefix, correct_prefix))
+        p "#{id.value} - #{id.valid?}"
+        p id.errors.full_messages
+      end
+    end
+  end
+
 end