rubocop -A

Author: aaronskiba

app/controllers/concerns/paginable.rb

@@ -214,7 +214,6 @@ def stringify_nonpagination_query_params
   def stringify_query_params(page: 1, search: @args[:search],
                              sort_field: @args[:sort_field],
                              sort_direction: nil)
-
     query_string = { page: page }
     query_string['search'] = search if search.present?
     if sort_field.present?

app/models/template.rb

@@ -284,7 +284,7 @@ def deep_copy(attributes: {}, **options)
     copy = dup
     if attributes.respond_to?(:each_pair)
       attributes.each_pair do |attribute, value|
-        copy.send(:"#{attribute}=".to_sym, value) if copy.respond_to?(:"#{attribute}=".to_sym)
+        copy.send(:"#{attribute}=", value) if copy.respond_to?(:"#{attribute}=")
       end
     end
     copy.save! if options.fetch(:save, false)

app/services/external_apis/base_service.rb

@@ -65,7 +65,7 @@ def handle_http_failure(method:, http_response:)
 
       # Logs the results of a failed HTTP response
       def handle_uri_failure(method:, uri:)
-        msg = "received an invalid uri: '#{uri&.to_s}'!"
+        msg = "received an invalid uri: '#{uri}'!"
         log_error(method: method, error: ExternalApiError.new(msg))
       end
 

app/services/org_selection/hash_to_org_service.rb

@@ -40,16 +40,15 @@ def to_org(hash:, allow_create: true)
         allow_create ? initialize_org(hash: hash) : nil
       end
 
-      # rubocop:disable Metrics/AbcSize
       def to_identifiers(hash:)
         return [] unless hash.present?
 
         out = []
         # Process each of the identifiers
         hash = hash.with_indifferent_access
-        idents = hash.select { |k, _v| identifier_keys.include?(k) }
+        idents = hash.slice(*identifier_keys)
         idents.each do |key, value|
-          attrs = hash.select { |k, _v| attr_keys(hash: hash).include?(k) }
+          attrs = hash.slice(*attr_keys(hash: hash))
           attrs = {} unless attrs.present?
           out << Identifier.new(
             identifier_scheme_id: IdentifierScheme.by_name(key).first&.id,
@@ -59,7 +58,6 @@ def to_identifiers(hash:)
         end
         out
       end
-      # rubocop:enable Metrics/AbcSize
 
       private
 
@@ -71,7 +69,7 @@ def lookup_org_by_id(hash:)
 
       # Lookup the Org by its :identifiers and return if the name matches the search
       def lookup_org_by_identifiers(hash:)
-        identifiers = hash.select { |k, _v| identifier_keys.include?(k) }
+        identifiers = hash.slice(*identifier_keys)
         ids = identifiers.map { |k, v| { name: k, value: v } }
         org = Org.from_identifiers(array: ids) if ids.any?
         exact_match?(rec: org, name2: hash[:name]) ? org : nil

lib/tasks/data_cleanup.rake

@@ -178,7 +178,7 @@ namespace :data_cleanup do
   # rubocop:disable Metrics/AbcSize
   def check_uniqueness(klass, filter)
     instance = klass.new
-    group = [filter.attributes.map { |a| instance.respond_to?(:"#{a}_id") ? :"#{a}_id".to_sym : a }]
+    group = [filter.attributes.map { |a| instance.respond_to?(:"#{a}_id") ? :"#{a}_id" : a }]
 
     group << filter.options[:scope] if filter.options[:scope].present?
     group = group.flatten.uniq