Merge pull request #2443 from DMPRoadmap/bug/role_perms

fix permissions bug for Notes#update and Roles#deactivate

Author: briri

app/policies/note_policy.rb

@@ -13,7 +13,7 @@ def create?
   end
 
   def update?
-    Plan.find(@note.answer.plan_id).commentable_by?(@user.id) && @note.user_id = @user.id
+    Plan.find(@note.answer.plan_id).commentable_by?(@user.id) && @note.user_id == @user.id
   end
 
   def archive?

app/policies/role_policy.rb

@@ -21,6 +21,6 @@ def destroy?
   end
 
   def deactivate?
-    @role.user_id = @user.id
+    @role.user_id == @user.id
   end
-end
+end