Skip to content

Conversation

@holke
Copy link
Collaborator

@holke holke commented Nov 27, 2025

Closes #1999

Describe your changes here:

Restrict MPI to be version 3.0 or higher.
3.0 is now over 15 years old and we can expect users to have it available.
3.0 introduced shared memory which we use a lot and knowing that it is available (b/c we enforce >=v3.0) make the code much more maintainable.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@holke holke added enhancement Enhances already existing code shouldn't take long Can be resolved in under 30 mins priority:medium Should be solved within half a year workload:low Would take half a day or less CMake Is about the CMake build system dependencies Pull requests that update a dependency file labels Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.60%. Comparing base (98ffe9d) to head (c6f5315).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1998   +/-   ##
=======================================
  Coverage   76.60%   76.60%           
=======================================
  Files         109      109           
  Lines       18721    18721           
=======================================
  Hits        14341    14341           
  Misses       4380     4380           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Davknapp Davknapp self-requested a review December 1, 2025 10:19
@Davknapp Davknapp self-assigned this Dec 1, 2025
@Davknapp Davknapp added this pull request to the merge queue Dec 1, 2025
Merged via the queue into main with commit 2235b3d Dec 1, 2025
38 checks passed
@Davknapp Davknapp deleted the feature-MPI_require_v3 branch December 1, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake Is about the CMake build system dependencies Pull requests that update a dependency file enhancement Enhances already existing code priority:medium Should be solved within half a year shouldn't take long Can be resolved in under 30 mins workload:low Would take half a day or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement: Restrict MPI to version 3.0 or higher

3 participants