New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong dimension conversion in pre-factor A #42

Open

jiweiqi opened this issue Sep 24, 2020 · 0 comments

Contributor

jiweiqi commented Sep 24, 2020 •

edited

Loading

reactorch/reactorch/import_kinetics.py

Line 285 in 7a03607

self.reactant_stoich_coeffs[:, i].sum().item() - 1)

This might should be done with reaction orders rather than stoichiometric coefficients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment