Merge feat/skip-pending-toggle: per-account skip-pending toggle (#17)

Author: David Alves

app/db.py

@@ -52,6 +52,7 @@ def _ensure_tables(conn):
         ("provider_credentials", "ALTER TABLE bank_accounts ADD COLUMN provider_credentials TEXT DEFAULT ''"),
         ("sync_mode", "ALTER TABLE bank_accounts ADD COLUMN sync_mode TEXT NOT NULL DEFAULT 'transactions'"),
         ("license_seat_id", "ALTER TABLE bank_accounts ADD COLUMN license_seat_id TEXT"),
+        ("skip_pending", "ALTER TABLE bank_accounts ADD COLUMN skip_pending INTEGER NOT NULL DEFAULT 0"),
     ]:
         try:
             conn.execute(sql)
@@ -198,7 +199,7 @@ def get_bank_account(account_id: int):
         return dict(row) if row else None
 
 def update_bank_account_field(account_id: int, field: str, value: str):
-    allowed = {"start_sync_date", "session_id", "account_uid", "session_expiry", "actual_account", "bank_name", "bank_country", "provider", "provider_credentials", "sync_mode", "license_seat_id"}
+    allowed = {"start_sync_date", "session_id", "account_uid", "session_expiry", "actual_account", "bank_name", "bank_country", "provider", "provider_credentials", "sync_mode", "license_seat_id", "skip_pending"}
     if field not in allowed:
         raise ValueError(f"Field {field} is not updatable")
     with _conn() as conn:

app/sync.py

@@ -329,9 +329,14 @@ def _sync_account(account, state):
             already_matched = existing[:]
             new_txn        = []
 
+            skip_pending = bool(account.get("skip_pending"))
+
             for txn in raw:
                 try:
                     status = txn.get("status", "BOOK")
+                    if status == "PDNG" and skip_pending:
+                        skipped += 1
+                        continue
                     date   = _parse_date(txn)
                     amount = _parse_amount(txn)
                     payee  = _parse_payee(txn)

app/web/server.py

@@ -1027,6 +1027,15 @@ def disconnect():
             logger.warning("Failed to release bank seat for %s: %s", account.get("bank_name"), result.get("error"))
     return redirect(url_for("bank"))
 
+@app.route("/toggle-skip-pending", methods=["POST"])
+def toggle_skip_pending():
+    account_id = request.form.get("account_id")
+    if account_id:
+        skip = "1" if request.form.get("skip_pending") == "1" else "0"
+        db.update_bank_account_field(int(account_id), "skip_pending", skip)
+        logger.info("Set skip_pending=%s for account %s", skip, account_id)
+    return redirect(url_for("bank"))
+
 @app.route("/reset-sync", methods=["POST"])
 def reset_sync():
     account_id = request.form.get("account_id")

app/web/templates/bank.html

@@ -101,6 +101,18 @@
         </form>
       </div>
       {% endif %}
+      {% if a.sync_mode != 'balance' %}
+      <div style="margin-top:8px;font-size:11px;color:#4a5568;">
+        <form method="POST" action="/toggle-skip-pending" style="display:inline;" id="skip-pending-form-{{ a.id }}">
+          <input type="hidden" name="account_id" value="{{ a.id }}">
+          <input type="hidden" name="skip_pending" value="{{ '0' if a.skip_pending else '1' }}">
+          <label style="display:inline-flex;align-items:center;gap:6px;cursor:pointer;margin:0;">
+            <input type="checkbox" {% if a.skip_pending %}checked{% endif %} onchange="document.getElementById('skip-pending-form-{{ a.id }}').submit();" style="cursor:pointer;margin:0;">
+            <span>Only sync booked transactions (skip pending)</span>
+          </label>
+        </form>
+      </div>
+      {% endif %}
     </div>
     {% endfor %}
     <hr style="border:none;border-top:1px solid #253450;margin:1.25rem 0;">