Crash when testing louvre-views

[Ramblurr]

I wanted to give louvre a little spin. I installed the nixos louvre package (version 2.9.0-1).

I run hyprland+wayland normally

Reproduce:

1. LOUVRE_DEBUG=4 SRM_DEBUG=4 louvre-views (result: a new window popups with louvre-view inside)
2. I press F1 to spawn a weston terminal (result: it works!)
3. In another terminal (outside louvre-views) I run WAYLAND_DISPLAY=wayland-2 kitty to run kitty inside louvre-views

this causes a crash:

... log snipped...

Louvre debug: [LGlobal] wp_content_type_manager_v1 created.
Louvre debug: [LGlobal] ext_idle_notifier_v1 created.
Louvre debug: [LGlobal] zwp_idle_inhibit_manager_v1 created.
Louvre debug: [LGlobal] xdg_activation_v1 created.
Louvre error: [LOpenGL::loadTexture] Failed to load image /home/ramblurr/.config/Louvre/wallpaper.jpg: can't fopen.
Louvre debug: Font Inter or similar found: /nix/store/xm9g2rcmg1q6d0pay259kwp5c9rgkbmy-noto-fonts-24.3.1/share/fonts/noto/NotoSans[wdth,wght].ttf
Louvre debug: Font Inter Semi Bold or similar found: /nix/store/xm9g2rcmg1q6d0pay259kwp5c9rgkbmy-noto-fonts-24.3.1/share/fonts/noto/NotoSans[wdth,wght].ttf
Louvre debug: [LLauncher::launch] Command dbus-update-activation-environment --systemd WAYLAND_DISPLAY XDG_CURRENT_DESKTOP=wlroots | systemctl --user restart xdg-desktop-portal executed successfuly. PID: 1850509.
Louvre debug: [LGlobal] wl_output created.
Louvre error: [LSurfacePrivate::bufferToTexture] Unknown buffer type. Killing client.
Louvre error: [RSurface::apply_commit] Failed to convert buffer to OpenGL texture.
Louvre debug: [LLauncher] Daemon exited with status 0.
zsh: segmentation fault (core dumped)  LOUVRE_DEBUG=4 SRM_DEBUG=4 louvre-views

Here is the crashinfo from coredumpctl.

           PID: 1850501 (louvre-views)
           UID: 1000 (ramblurr)
           GID: 1000 (ramblurr)
        Signal: 11 (SEGV)
     Timestamp: Thu 2024-09-26 10:47:58 CEST (38s ago)
  Command Line: louvre-views
    Executable: /nix/store/kh0ddgirbh4fbg2d4ixr5dsglzhx6d8w-louvre-2.9.0-1/bin/louvre-views
 Control Group: /user.slice/user-1000.slice/[email protected]/kitty-1708447-0.scope
          Unit: [email protected]
     User Unit: kitty-1708447-0.scope
         Slice: user-1000.slice
     Owner UID: 1000 (ramblurr)
       Boot ID: bfc3ef623229489490f034cef276286d
    Machine ID: 76913090587c40c8a3207202dfe86fc2
      Hostname: quine
       Storage: /var/lib/systemd/coredump/core.louvre-views.1000.bfc3ef623229489490f034cef276286d.1850501.1727340478000000.zst (present)
  Size on Disk: 6.2M
       Message: Process 1850501 (louvre-views) of user 1000 dumped core.
                
                Module wayland.so without build-id.
                Module libdisplay-info.so.2 without build-id.
                Module libXext.so.6 without build-id.
                Module libGLX.so.0 without build-id.
                Module libSRM.so.0 without build-id.
                Module libGL.so.1 without build-id.
                Module wayland.so without build-id.
                Module libxshmfence.so.1 without build-id.
                Module libxcb-sync.so.1 without build-id.
                Module libxcb-present.so.0 without build-id.
                Module libxcb-shm.so.0 without build-id.
                Module libxcb-xfixes.so.0 without build-id.
                Module libxcb-dri2.so.0 without build-id.
                Module libX11-xcb.so.1 without build-id.
                Module libpciaccess.so.0 without build-id.
                Module liblzma.so.5 without build-id.
                Module libxml2.so.2 without build-id.
                Module libncursesw.so.6 without build-id.
                Module libdrm_intel.so.1 without build-id.
                Module libdrm_amdgpu.so.1 without build-id.
                Module libdrm_radeon.so.1 without build-id.
                Module libsensors.so.5 without build-id.
                Module libxcb-dri3.so.0 without build-id.
                Module libzstd.so.1 without build-id.
                Module libxcb-randr.so.0 without build-id.
                Module libdrm.so.2 without build-id.
                Module libnvidia-egl-wayland.so without build-id.
                Module libXdmcp.so.6 without build-id.
                Module libXau.so.6 without build-id.
                Module libpcre2-8.so.0 without build-id.
                Module libxcb.so.1 without build-id.
                Module libbrotlicommon.so.1 without build-id.
                Module libgudev-1.0.so.0 without build-id.
                Module libcap.so.2 without build-id.
                Module libX11.so.6 without build-id.
                Module libXfixes.so.3 without build-id.
                Module libXrender.so.1 without build-id.
                Module libGLdispatch.so.0 without build-id.
                Module libffi.so.8 without build-id.
                Module libicudata.so.74 without build-id.
                Module libexpat.so.1 without build-id.
                Module libbrotlidec.so.1 without build-id.
                Module libpng16.so.16 without build-id.
                Module libbz2.so.1 without build-id.
                Module libz.so.1 without build-id.
                Module libwacom.so.9 without build-id.
                Module libevdev.so.2 without build-id.
                Module libmtdev.so.1 without build-id.
                Module libseat.so.1 without build-id.
                Module libxkbcommon.so.0 without build-id.
                Module libXcursor.so.1 without build-id.
                Module libGLESv2.so.2 without build-id.
                Module libEGL.so.1 without build-id.
                Module libgcc_s.so.1 without build-id.
                Module libstdc++.so.6 without build-id.
                Module libicuuc.so.74 without build-id.
                Module libfreetype.so.6 without build-id.
                Module libfontconfig.so.1 without build-id.
                Module libinput.so.10 without build-id.
                Module libLouvre.so.2 without build-id.
                Module louvre-views without build-id.
                Stack trace of thread 1850501:
                #0  0x00007fb47acec575 wl_map_lookup (libwayland-server.so.0 + 0x10575)
                #1  0x00007fb47ace5cba wl_client_connection_data (libwayland-server.so.0 + 0x9cba)
                #2  0x00007fb47ace8ed2 wl_event_loop_dispatch (libwayland-server.so.0 + 0xced2)
                #3  0x00007fb47b2b670a _ZN6Louvre11LCompositor11processLoopEi (libLouvre.so.2 + 0x6170a)
                #4  0x000000000040f815 main (louvre-views + 0xf815)
                #5  0x00007fb47a83314e __libc_start_call_main (libc.so.6 + 0x2a14e)
                #6  0x00007fb47a833209 __libc_start_main@@GLIBC_2.34 (libc.so.6 + 0x2a209)
                #7  0x000000000040f8b5 _start (louvre-views + 0xf8b5)
                
                Stack trace of thread 1850503:
                #0  0x00007fb47a90ad1f __poll (libc.so.6 + 0x101d1f)
                #1  0x00007fb477f74993 _ZN6Louvre15LGraphicBackend10renderLoopEv (wayland.so + 0xc993)
                #2  0x00007fb47aae86d3 execute_native_thread_routine (libstdc++.so.6 + 0xe86d3)
                #3  0x00007fb47a899a42 start_thread (libc.so.6 + 0x90a42)
                #4  0x00007fb47a91905c __clone3 (libc.so.6 + 0x11005c)
                
                Stack trace of thread 1850520:
                #0  0x00007fb47a8960ce __futex_abstimed_wait_common (libc.so.6 + 0x8d0ce)
                #1  0x00007fb47a898c20 pthread_cond_wait@@GLIBC_2.3.2 (libc.so.6 + 0x8fc20)
                #2  0x00007fb477cb9c38 n/a (libEGL_nvidia.so.0 + 0xb9c38)
                #3  0x00007fb477c8a4c1 n/a (libEGL_nvidia.so.0 + 0x8a4c1)
                #4  0x00007fb477cbfcce n/a (libEGL_nvidia.so.0 + 0xbfcce)
                #5  0x00007fb47a899a42 start_thread (libc.so.6 + 0x90a42)
                #6  0x00007fb47a91905c __clone3 (libc.so.6 + 0x11005c)
                
                Stack trace of thread 1850505:
                #0  0x00007fb47a90ad1f __poll (libc.so.6 + 0x101d1f)
                #1  0x00007fb47827f3c5 buffer_release_thread (libnvidia-egl-wayland.so + 0x93c5)
                #2  0x00007fb47a899a42 start_thread (libc.so.6 + 0x90a42)
                #3  0x00007fb47a91905c __clone3 (libc.so.6 + 0x11005c)
                
                Stack trace of thread 1850522:
                #0  0x00007fb47a8960ce __futex_abstimed_wait_common (libc.so.6 + 0x8d0ce)
                #1  0x00007fb47a898c20 pthread_cond_wait@@GLIBC_2.3.2 (libc.so.6 + 0x8fc20)
                #2  0x00007fb477cb9c38 n/a (libEGL_nvidia.so.0 + 0xb9c38)
                #3  0x00007fb477cb9db5 n/a (libEGL_nvidia.so.0 + 0xb9db5)
                #4  0x00007fb477c9ecd8 n/a (libEGL_nvidia.so.0 + 0x9ecd8)
                #5  0x00007fb477ca0133 n/a (libEGL_nvidia.so.0 + 0xa0133)
                #6  0x00007fb477c49614 n/a (libEGL_nvidia.so.0 + 0x49614)
                #7  0x00007fb478281bd4 damage_thread (libnvidia-egl-wayland.so + 0xbbd4)
                #8  0x00007fb47a899a42 start_thread (libc.so.6 + 0x90a42)
                #9  0x00007fb47a91905c __clone3 (libc.so.6 + 0x11005c)
                
                Stack trace of thread 1850511:
                #0  0x00007fb47a90ad1f __poll (libc.so.6 + 0x101d1f)
                #1  0x00007fb4767f69f7 n/a (libnvidia-eglcore.so.550.107.02 + 0x9f69f7)
                #2  0x00007fb4767f4faa n/a (libnvidia-eglcore.so.550.107.02 + 0x9f4faa)
                #3  0x00007fb47a899a42 start_thread (libc.so.6 + 0x90a42)
                #4  0x00007fb47a91905c __clone3 (libc.so.6 + 0x11005c)
                ELF object binary architecture: AMD x86-64

Here is what the output of the kitty command is:

$ WAYLAND_DISPLAY=wayland-2 kitty
[0.220] [glfw error 65544]: EGL: Failed to create window surface: EGL failed to allocate resources for the requested operation
[0.229] Traceback (most recent call last):
  File "/nix/store/bvndrzf31dr07pc88q6mwqn6r7wvp4af-kitty-0.36.1/bin/../lib/kitty/kitty/main.py", line 531, in main
    _main()
  File "/nix/store/bvndrzf31dr07pc88q6mwqn6r7wvp4af-kitty-0.36.1/bin/../lib/kitty/kitty/main.py", line 523, in _main
    run_app(opts, cli_opts, bad_lines, talk_fd)
  File "/nix/store/bvndrzf31dr07pc88q6mwqn6r7wvp4af-kitty-0.36.1/bin/../lib/kitty/kitty/main.py", line 253, in __call__
    _run_app(opts, args, bad_lines, talk_fd)
  File "/nix/store/bvndrzf31dr07pc88q6mwqn6r7wvp4af-kitty-0.36.1/bin/../lib/kitty/kitty/main.py", line 222, in _run_app
    window_id = create_os_window(
                ^^^^^^^^^^^^^^^^^
ValueError: Failed to create GLFWwindow

[ehopperdietzel]

Hi, thanks for reporting this issue!

There are two unusual things happening:

1. The surface buffer type provided by kitty is not being recognized by Louvre.
2. The compositor crashes when it attempts to kill kitty (due to the invalid buffer).

In my setup, I don't encounter this error and kitty works fine. However, I simulated providing an invalid buffer, and the compositor indeed crashes. I've replaced the wl_client_destroy call with wl_resource_post_error (which also destroys the client) here, and this prevents the segfault. It seems that calling wl_client_destroy while dispatching events is no longer safe, possibly due to recent changes in libwayland-server as I remember testing this earlier without issues. The fix is available in the devel branch if you'd like to test it.

As for issue N°1, I'm not entirely sure what could be causing it. Could you provide me with the following information?

• Are you launching louvre-views from a TTY or inside another Wayland compositor?
• The full log from this command (launched from a free TTY): SRM_DEBUG=4 LOUVRE_DEBUG=4 louvre-views > louvre_views_log.txt 2>&1
• The complete output of running drm_info > drm_info_log.txt 2>&1

With this information, I should be able to track down what's going on. Thanks in advance!

[ehopperdietzel]

Hi @Ramblurr, sorry if I overwhelmed you with all the questions, haha. If you try the latest Louvre release, could you let me know if the issue is fixed?