Fix golangci-lint issues and add pre-commit

Author: Omicron7

.github/workflows/test.yml

@@ -33,6 +33,7 @@ jobs:
         uses: golangci/golangci-lint-action@v6
         with:
           version: latest
+          args: --tests=false
 
   generate:
     runs-on: ubuntu-latest

.pre-commit-config.yaml

@@ -0,0 +1,9 @@
+# See https://pre-commit.com for more information
+# See https://pre-commit.com/hooks.html for more hooks
+repos:
+-   repo: https://github.com/golangci/golangci-lint
+    rev: v1.62.2
+    hooks:
+    -   id: golangci-lint
+        args:
+            - "--tests=false"

.tool-versions

@@ -0,0 +1,2 @@
+terraform 1.9.8
+pre-commit 4.0.1

Taskfile.yml

@@ -21,7 +21,7 @@ tasks:
   lint:
     desc: Run the linter
     cmds:
-      - golangci-lint run
+      - golangci-lint run --tests=false
 
   generate:
     desc: Generate documentation

internal/provider/project_template_resource.go

@@ -486,7 +486,7 @@ func convertTemplateResponseToProjectTemplateModel(ctx context.Context, request
 		}
 	}
 
-	if request.SurveyVars == nil || len(request.SurveyVars) == 0 {
+	if len(request.SurveyVars) == 0 {
 		model.SurveyVars = prev.SurveyVars
 	} else {
 		var surveyVars []projectTemplateSurveyVarModel
@@ -513,7 +513,7 @@ func convertTemplateResponseToProjectTemplateModel(ctx context.Context, request
 		model.SurveyVars = surveyVarsModel
 	}
 
-	if request.Vaults == nil || len(request.Vaults) == 0 {
+	if len(request.Vaults) == 0 {
 		model.Vaults = prev.Vaults
 	} else {
 		sort.Sort(ByVaultID(request.Vaults))