Add comprehensive E2E test framework with Playwright #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraible
force-pushed
the
add-e2e-tests
branch
from
86f02db to
3c215f0
Compare
mraible
force-pushed
the
add-e2e-tests
branch
from
e44f49e to
c70c38e
Compare
- Update AppCatalogPage waitForInstallation() to wait for both 'installing' and 'installed' toast messages sequentially - Throw clear error if 'installing' message never appears - Wait up to 60s for final 'installed' or 'error' message - Detect and report installation failures immediately
…k extraction - Rename configureServiceNowIfNeeded() to configureApiIntegrationIfNeeded() - Add comprehensive documentation explaining the method is designed for framework extraction - Note that method is a no-op for apps without API integrations - Mark with @future-framework-extraction tag for easy identification during extraction
The app requires clicking the app button to expand a submenu, then clicking the link within that submenu to navigate. This matches the blog post pattern and uses: - RetryHandler.withPlaywrightRetry() for automatic retries - smartClick() for reliable interaction - page.waitForURL() to confirm navigation completed All 10 tests now pass.
…AppCatalogPage - Update harden-runner to v2.13.2 - Update Homebrew action comment to 2024-10-25 - Update setup-node to v4.1.0 - Update create-envfile to v2.0.3 - Update upload-artifact to v4.5.0 - Remove ServiceNow-specific references from configureApiIntegrationIfNeeded method - Replace with generic API integration pattern that works for any app
- Update upload-artifact to v5.0.0 (latest) - Update harden-runner to v2.13.2 - Update checkout to v4.2.2 - Update setup-go to v5.1.0 - Update setup-node to v4.1.0 - Update borales/actions-yarn to v5.3.0 - Update peter-evans/create-pull-request to v7.0.5 - Remove duplicate checkout/setup-node in rebuild.yml
This app has no API integration configuration, so the method should be empty.
The method is required by BasePage but never called for this page object since navigation is done via Custom Apps menu. Return empty string instead of throwing an error.
Changes getCurrentUrl() and waiter from protected to public in BasePage, allowing direct access from tests instead of using bracket notation workaround. This improves type safety and code clarity.
- Update harden-runner to v2.13.2 in both workflows - Accept latest action versions from main branch
prvn
approved these changes
Nov 12, 2025
mraible
commented
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements end-to-end testing infrastructure for Foundry Scalable RTR app with automated install-test-uninstall cycle.
Key features:
Test coverage:
Framework components:
CI/CD: