Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init-max-area with an aspect-ratio lower than 1 not working #81

Open
roux1max opened this issue Oct 24, 2018 · 6 comments
Open

init-max-area with an aspect-ratio lower than 1 not working #81

roux1max opened this issue Oct 24, 2018 · 6 comments

Comments

@roux1max
Copy link
Contributor

If the init-max-area binding is set to true and the provided aspect-ratio in lower than 1 (portrait area required), the init-max-area is not applied and the crop area is positionned in the center not reaching neither the height nor width.

I tried different things but nothing is working.

@roux1max
Copy link
Contributor Author

roux1max commented Nov 8, 2018

Up !

@CrackerakiUA
Copy link
Owner

create codepen, I will check

@roux1max
Copy link
Contributor Author

CodePen : https://codepen.io/anon/pen/EOWwGv

The behavior I am describing is only true if you upload a portrait image (height greater than width).

@CrackerakiUA
Copy link
Owner

ok, I see, i believe I know how to solve that. Will try to check it within few next days. You can also check if you want to.

@roux1max
Copy link
Contributor Author

Awesome ! Thank you !
I will check when you make the PR !

Btw, do you need help for maintaining the project ?

@CrackerakiUA
Copy link
Owner

Well, I don't have much time for public repos currently. Any PR is accepted if it not brake any of mine codepen.

roux1max pushed a commit to roux1max/ui-cropper that referenced this issue Nov 21, 2018
CrackerakiUA added a commit that referenced this issue Nov 25, 2018
Fix issue #81 - init-max-area with an aspect-ratio lower than 1 not working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants