Skip to content

Commit 63d04cd

Browse files
author
Daniel Dahan
committed
removed c-style for loops
1 parent 22e4dab commit 63d04cd

10 files changed

+24
-21
lines changed

Sources/RedBlackTree.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@ public class RedBlackTree<Key : Comparable, Value> : ProbableType, CollectionTyp
5858
*/
5959
internal var internalDescription: String {
6060
var output: String = "["
61-
for var i: Int = 0, l = count - 1; i <= l; ++i {
61+
let l: Int = count - 1
62+
for i in 0..<count {
6263
output += "\(self[i])"
6364
if i != l {
6465
output += ", "
@@ -765,7 +766,7 @@ public func ==<Key : Comparable, Value>(lhs: RedBlackTree<Key, Value>, rhs: RedB
765766
if lhs.count != rhs.count {
766767
return false
767768
}
768-
for var i: Int = lhs.count - 1; 0 <= i; --i {
769+
for i in 0..<lhs.count {
769770
if lhs[i].key != rhs[i].key {
770771
return false
771772
}

Sources/SortedDictionary.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ public func ==<Key : Comparable, Value>(lhs: SortedDictionary<Key, Value>, rhs:
390390
if lhs.count != rhs.count {
391391
return false
392392
}
393-
for var i: Int = lhs.count - 1; 0 <= i; --i {
393+
for i in 0..<lhs.count {
394394
if lhs[i].key != rhs[i].key {
395395
return false
396396
}

Sources/SortedMultiDictionary.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ public func ==<Key : Hashable, Value>(lhs: SortedMultiDictionary<Key, Value>, rh
390390
if lhs.count != rhs.count {
391391
return false
392392
}
393-
for var i: Int = lhs.count - 1; 0 <= i; --i {
393+
for i in 0..<lhs.count {
394394
if lhs[i].key != rhs[i].key {
395395
return false
396396
}

Sources/SortedMultiSet.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@ public class SortedMultiSet<Element : Comparable> : ProbableType, CollectionType
6262
*/
6363
public var description: String {
6464
var output: String = "["
65-
for var i: Int = 0, l = count - 1; i <= l; ++i {
65+
let l: Int = count - 1
66+
for i in 0..<count {
6667
output += "\(self[i])"
6768
if i != l {
6869
output += ", "
@@ -624,7 +625,7 @@ public func ==<Element: Comparable>(lhs: SortedMultiSet<Element>, rhs: SortedMul
624625
if lhs.count != rhs.count {
625626
return false
626627
}
627-
for var i: Int = lhs.count - 1; 0 <= i; --i {
628+
for i in 0..<lhs.count {
628629
if lhs[i] != rhs[i] {
629630
return false
630631
}

Sources/SortedSet.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@ public class SortedSet<Element : Comparable> : ProbableType, CollectionType, Com
6262
*/
6363
public var description: String {
6464
var output: String = "["
65-
for var i: Int = 0, l = count - 1; i <= l; ++i {
65+
let l: Int = count - 1
66+
for i in 0..<count {
6667
output += "\(self[i])"
6768
if i != l {
6869
output += ", "
@@ -607,7 +608,7 @@ public func ==<Element: Comparable>(lhs: SortedSet<Element>, rhs: SortedSet<Elem
607608
if lhs.count != rhs.count {
608609
return false
609610
}
610-
for var i: Int = lhs.count - 1; 0 <= i; --i {
611+
for i in 0..<lhs.count {
611612
if lhs[i] != rhs[i] {
612613
return false
613614
}

Tests/RedBlackTreeTests.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class RedBlackTreeTests: XCTestCase {
4646

4747
XCTAssert(0 == s.count, "Test failed, got \(s.count).")
4848

49-
for var i: Int = 1000; 0 < i; --i {
49+
for _ in 0..<1000 {
5050
s.insert(1, value: 1)
5151
s.insert(2, value: 2)
5252
s.insert(3, value: 3)
@@ -57,7 +57,7 @@ class RedBlackTreeTests: XCTestCase {
5757
XCTAssert(2 == s[1].value, "Test failed.")
5858
XCTAssert(3 == s[2].value, "Test failed.")
5959

60-
for var i: Int = 500; 0 < i; --i {
60+
for _ in 0..<500 {
6161
s.removeValueForKeys(1)
6262
s.removeValueForKeys(3)
6363
}
@@ -77,7 +77,7 @@ class RedBlackTreeTests: XCTestCase {
7777
s.insert(2, value: 2)
7878
s.insert(3, value: 3)
7979

80-
for var i: Int = s.endIndex - 1; i >= s.startIndex; --i {
80+
for i in s.startIndex..<s.endIndex {
8181
s[i] = (s[i].key, 100)
8282
XCTAssert(100 == s[i].value, "Test failed.")
8383
}
@@ -113,11 +113,11 @@ class RedBlackTreeTests: XCTestCase {
113113

114114
let t3: RedBlackTree<Int, Int> = t1 + t2
115115

116-
for var i: Int = t1.count - 1; 0 <= i; --i {
116+
for i in 0..<t1.count {
117117
XCTAssert(t1[i].value == t3.findValueForKey(t1[i].value!), "Test failed.")
118118
}
119119

120-
for var i: Int = t2.count - 1; 0 <= i; --i {
120+
for i in 0..<t2.count {
121121
XCTAssert(t2[i].value == t3.findValueForKey(t2[i].value!), "Test failed.")
122122
}
123123
}

Tests/SortedDictionaryTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class SortedDictionaryTests: XCTestCase {
4646

4747
XCTAssert(0 == s.count, "Test failed, got \(s.count).")
4848

49-
for var i: Int = 1000; 0 < i; --i {
49+
for _ in 0..<1000 {
5050
s.insert((1, 1))
5151
s.insert((2, 2))
5252
s.insert((3, 3))
@@ -57,7 +57,7 @@ class SortedDictionaryTests: XCTestCase {
5757
XCTAssert(2 == s[1].value, "Test failed.")
5858
XCTAssert(3 == s[2].value, "Test failed.")
5959

60-
for var i: Int = 500; 0 < i; --i {
60+
for _ in 0..<500 {
6161
s.removeValueForKeys(1)
6262
s.removeValueForKeys(3)
6363
}

Tests/SortedMultiDictionaryTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class SortedMultiDictionaryTests: XCTestCase {
4646

4747
XCTAssert(0 == s.count, "Test failed, got \(s.count).")
4848

49-
for var i: Int = 1000; 0 < i; --i {
49+
for _ in 0..<1000 {
5050
s.insert((1, 1))
5151
s.insert((2, 2))
5252
s.insert((3, 3))
@@ -57,7 +57,7 @@ class SortedMultiDictionaryTests: XCTestCase {
5757
XCTAssert(1 == s[1].value, "Test failed.")
5858
XCTAssert(1 == s[2].value, "Test failed.")
5959

60-
for var i: Int = 500; 0 < i; --i {
60+
for _ in 0..<500 {
6161
s.removeValueForKeys(1)
6262
s.removeValueForKeys(3)
6363
}

Tests/SortedMultiSetTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class SortedMultiSetTests: XCTestCase {
4646

4747
XCTAssert(0 == s.count, "Test failed, got \(s.count).")
4848

49-
for var i: Int = 1000; i > 0; --i {
49+
for _ in 0..<1000 {
5050
s.insert(1)
5151
s.insert(2)
5252
s.insert(3)
@@ -57,7 +57,7 @@ class SortedMultiSetTests: XCTestCase {
5757
XCTAssert(2 == s[1000], "Test failed.")
5858
XCTAssert(3 == s[2000], "Test failed.")
5959

60-
for var i: Int = 500; i > 0; --i {
60+
for _ in 0..<500 {
6161
s.remove(1)
6262
s.remove(3)
6363
}

Tests/SortedSetTest.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class SortedSetTests: XCTestCase {
4646

4747
XCTAssert(0 == s.count, "Test failed, got \(s.count).")
4848

49-
for var i: Int = 1000; i > 0; --i {
49+
for _ in 0..<1000 {
5050
s.insert(1)
5151
s.insert(2)
5252
s.insert(3)
@@ -57,7 +57,7 @@ class SortedSetTests: XCTestCase {
5757
XCTAssert(2 == s[1], "Test failed.")
5858
XCTAssert(3 == s[2], "Test failed.")
5959

60-
for var i: Int = 500; i > 0; --i {
60+
for _ in 0..<500 {
6161
s.remove(1)
6262
s.remove(3)
6363
}

0 commit comments

Comments
 (0)