Skip to content

Review and unify API calls #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ethanfrey opened this issue Jan 27, 2021 · 2 comments
Closed

Review and unify API calls #756

ethanfrey opened this issue Jan 27, 2021 · 2 comments

Comments

@ethanfrey
Copy link
Member

ethanfrey commented Jan 27, 2021

Part of #751
Requires #752, #753, #754, #755

  • Revisit the various method calls that were created as part of the implementation of the other PRs
  • Modify it as needed to make it as clear/readable as possible
  • Consider if a crypto feature flag makes sense. (Do unit tests of non-crypto contracts take much longer to compile/run?)
  • Update tests
@ethanfrey
Copy link
Member Author

I guess this has already been done?
Or is there anything left?

@webmaster128
Copy link
Member

I am not aware of anything specifric enough to do right now. Insights will come with use cases. But those are better tracked in specific tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants