Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect tag filter application for AWS KMS in eth1 mode #1052

Open
usmansaleem opened this issue Jan 13, 2025 · 0 comments
Open

Incorrect tag filter application for AWS KMS in eth1 mode #1052

usmansaleem opened this issue Jan 13, 2025 · 0 comments
Assignees
@usmansaleem
Labels
bug Something isn't working EL Execution layer P3 Medium TeamCerberus Under active development by TeamCerberus @Consensys

Comments

@usmansaleem
Copy link
Contributor

Web3Signer has incorrect tag based filtering for AWS KMS in eth1 mode. When a tag name or tag value is specified in config file for bulk mode, KMS keys without any tag names or tag values are also returned.

Expected outcome:
When tag names or tag values are specified, then only keys matching those tag names/values should be returned.

Dev notes:
The Web3Signer kms tag filter options should be combined into single cli option (similar to AWS cli option for KMS) i.e. something on the lines of:

--aws-kms-tags='TagKey="string",TagValue="string", TagKey="string",TagValue="",...'
@usmansaleem usmansaleem added bug Something isn't working TeamCerberus Under active development by TeamCerberus @Consensys P3 Medium EL Execution layer labels Jan 13, 2025
@usmansaleem usmansaleem self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usmansaleem usmansaleem

Labels
bug Something isn't working EL Execution layer P3 Medium TeamCerberus Under active development by TeamCerberus @Consensys
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@usmansaleem