Skip to content

Validation for Field Elements #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DavePearce opened this issue Aug 1, 2024 · 2 comments · May be fixed by #909
Open

Validation for Field Elements #282

DavePearce opened this issue Aug 1, 2024 · 2 comments · May be fixed by #909
Labels
good first issue Good for newcomers

Comments

@DavePearce
Copy link
Collaborator

I think there is an interesting issue with respect to validation of field elements. Specifically, whenever we see a field element which fits within 256bits we are happy. But, in fact, it should be within 254 bits. It would be useful to sanity check this.
@DavePearce DavePearce added the good first issue Good for newcomers label Jan 21, 2025
@albertyosef
Copy link

hey @DavePearce can i get assigned to this issue

This was referenced May 28, 2025
Closed
Open
@albertyosef
Copy link

@DavePearce I apologize for the earlier confusion where I accidentally pushed the changes to my forked repository (albertyosef#1). I've now created the PR in the correct repository (consensys/go-corset).

You can find the changes here: #909

Thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate field elements to ensure 254-bit constraint albertyosef/go-corset
2 participants
@DavePearce @albertyosef