Skip to content

Commit dea0b0c

Browse files
committed
chore(signer): add TODO for BlsPublicKey wrapper
1 parent 0ff2091 commit dea0b0c

File tree

1 file changed

+6
-2
lines changed
  • crates/common/src/signer/schemes

1 file changed

+6
-2
lines changed

crates/common/src/signer/schemes/bls.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ use crate::{
1515

1616
pub type BlsSecretKey = blst::min_pk::SecretKey;
1717

18+
// TODO(David):
19+
// This wrapper type is potentially a temporary solution, merely to implement
20+
// `TreeHash`. Remove when progress is made on this issue (https://github.com/sigp/tree_hash/issues/22)
21+
// or refine the boundaries between our wrapper `BlsPublicKey` type
22+
// and alloy's `BlsPublicKey` if we stick with it
23+
1824
// std traits
1925
#[derive(Debug, Clone, Copy, LowerHex, Display, PartialEq, Eq, Hash, Default)]
2026
// serde, ssz, tree_hash
@@ -79,8 +85,6 @@ fn random_secret() -> BlsSecretKey {
7985
}
8086
}
8187

82-
// TODO(David): Refine the boundaries between our wrapper `BlsPublicKey` type
83-
// and alloy's `BlsPublicKey`. This stinks right now...
8488
pub fn verify_bls_signature(
8589
pubkey: &BlsPublicKeyInner,
8690
msg: &[u8],

0 commit comments

Comments
 (0)