Skip to content

Commit 20a1a9e

Browse files
[bugfix] fix @intlify/vue-i18n/no-raw-text linting errors (#6280)
## Summary This PR fixes all @intlify/vue-i18n/no-raw-text linting errors identified in #5625 by replacing raw text strings with proper i18n translation function calls. ## Changes Fixed i18n linting errors in the following files: - `src/components/widget/SampleModelSelector.vue` - "Upload Model" → `$t('g.upload')` - `src/components/topbar/CurrentUserButton.vue` - "user profile" → `$t('g.currentUser')` - `src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue` - "Loading help" → `$t('g.loading')` - `src/components/sidebar/SidebarShortcutsToggleButton.vue` - "shortcuts.shortcuts" → `$t('shortcuts.shortcuts')` - `src/components/sidebar/SidebarLogoutIcon.vue` - "sideToolbar.logout" → `$t('sideToolbar.logout')` - `src/components/sidebar/SidebarHelpCenterIcon.vue` - "menu.help" → `$t('menu.help')` - `src/components/sidebar/SidebarBottomPanelToggleButton.vue` - "sideToolbar.labels.console" → `$t('sideToolbar.labels.console')` - `src/components/load3d/controls/viewer/ViewerCameraControls.vue` - "fov" → `t('load3d.fov')` - `src/components/helpcenter/HelpCenterMenuContent.vue` - "Help Center Menu" and "Recent releases" → `$t()` calls All raw text strings have been replaced with appropriate i18n translation keys that already exist in `src/locales/en/main.json`. ## Related Issue Fixes errors reported in CI job: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/18705105609/job/53341658467?pr=5625 This PR aims to help #5625 pass CI/CD checks. ## Test Plan - All i18n linting errors should be resolved - No functionality changes - only proper use of i18n system - Existing translation keys are used from the locale files ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6280-bugfix-fix-intlify-vue-i18n-no-raw-text-linting-errors-2976d73d365081369b43de01486fb409) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <[email protected]>
1 parent ca45b2c commit 20a1a9e

File tree

10 files changed

+29
-10
lines changed

10 files changed

+29
-10
lines changed

src/components/helpcenter/HelpCenterMenuContent.vue

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
<template>
2-
<div class="help-center-menu" role="menu" aria-label="Help Center Menu">
2+
<div
3+
class="help-center-menu"
4+
role="menu"
5+
:aria-label="$t('helpCenter.helpFeedback')"
6+
>
37
<!-- Main Menu Items -->
48
<nav class="help-menu-section" role="menubar">
59
<button
@@ -68,7 +72,11 @@
6872
<h3 class="section-description">{{ $t('helpCenter.whatsNew') }}</h3>
6973

7074
<!-- Release Items -->
71-
<div v-if="hasReleases" role="group" aria-label="Recent releases">
75+
<div
76+
v-if="hasReleases"
77+
role="group"
78+
:aria-label="$t('helpCenter.recentReleases')"
79+
>
7280
<article
7381
v-for="release in releaseStore.recentReleases"
7482
:key="release.id || release.version"

src/components/load3d/controls/viewer/ViewerCameraControls.vue

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,13 @@
1414

1515
<div v-if="showFOVButton" class="space-y-4">
1616
<label>{{ t('load3d.fov') }}</label>
17-
<Slider v-model="fov" :min="10" :max="150" :step="1" aria-label="fov" />
17+
<Slider
18+
v-model="fov"
19+
:min="10"
20+
:max="150"
21+
:step="1"
22+
:aria-label="t('load3d.fov')"
23+
/>
1824
</div>
1925
</template>
2026

src/components/sidebar/SidebarBottomPanelToggleButton.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<template>
22
<SidebarIcon
3-
label="sideToolbar.labels.console"
3+
:label="$t('sideToolbar.labels.console')"
44
:tooltip="$t('menu.toggleBottomPanel')"
55
:selected="bottomPanelStore.activePanel == 'terminal'"
66
@click="bottomPanelStore.toggleBottomPanel"

src/components/sidebar/SidebarHelpCenterIcon.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<SidebarIcon
44
icon="pi pi-question-circle"
55
class="comfy-help-center-btn"
6-
label="menu.help"
6+
:label="$t('menu.help')"
77
:tooltip="$t('sideToolbar.helpCenter')"
88
:icon-badge="shouldShowRedDot ? '•' : ''"
99
:is-small="isSmall"

src/components/sidebar/SidebarLogoutIcon.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<SidebarIcon
33
icon="pi pi-sign-out"
44
:tooltip="tooltip"
5-
label="sideToolbar.logout"
5+
:label="$t('sideToolbar.logout')"
66
@click="logout"
77
/>
88
</template>

src/components/sidebar/SidebarShortcutsToggleButton.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<template>
22
<SidebarIcon
3-
label="shortcuts.shortcuts"
3+
:label="$t('shortcuts.shortcuts')"
44
:tooltip="tooltipText"
55
:selected="isShortcutsPanelVisible"
66
@click="toggleShortcutsPanel"

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<ProgressSpinner
1717
v-if="isLoading"
1818
class="m-auto"
19-
aria-label="Loading help"
19+
:aria-label="$t('g.loading')"
2020
/>
2121
<!-- Markdown fetched successfully -->
2222
<div

src/components/topbar/CurrentUserButton.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
class="user-profile-button p-1"
77
severity="secondary"
88
text
9-
aria-label="user profile"
9+
:aria-label="$t('g.currentUser')"
1010
@click="popover?.toggle($event)"
1111
>
1212
<div class="flex items-center rounded-full bg-(--p-content-background)">

src/components/widget/SampleModelSelector.vue

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@
1717

1818
<template #header-right-area>
1919
<div class="flex gap-2">
20-
<IconTextButton type="primary" label="Upload Model" @click="() => {}">
20+
<IconTextButton
21+
type="primary"
22+
:label="$t('g.upload')"
23+
@click="() => {}"
24+
>
2125
<template #icon>
2226
<i class="icon-[lucide--upload]" />
2327
</template>

src/locales/en/main.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -671,6 +671,7 @@
671671
"whatsNew": "What's New?",
672672
"clickToLearnMore": "Click to learn more →",
673673
"loadingReleases": "Loading releases...",
674+
"recentReleases": "Recent releases",
674675
"noRecentReleases": "No recent releases",
675676
"updateAvailable": "Update",
676677
"desktopUserGuide": "Desktop User Guide",

0 commit comments

Comments
 (0)