Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved remove duplicates #1034

Merged
merged 15 commits into from
Dec 28, 2024
Merged

Improved remove duplicates #1034

merged 15 commits into from
Dec 28, 2024

Conversation

girishpanchal30
Copy link
Contributor

@girishpanchal30 girishpanchal30 commented Dec 17, 2024 •
edited
Loading

Summary

I have enhanced the duplicate removal process during import based on the suggestion provided here: #1006 (comment)

Will affect visual aspect of the product

Yes

Screenshots

image

Check before Pull Request is ready:

Closes #1006

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Dec 17, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 17, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Dec 17, 2024 •
edited
Loading

Plugin build for d5a33ba is ready 🛎️!

@girishpanchal30 girishpanchal30 mentioned this pull request Dec 17, 2024
Open
@girishpanchal30 girishpanchal30 linked an issue Dec 17, 2024 that may be closed by this pull request
[PRO] Improve the way we remove duplicates during the import #1006
Open
@selul
Copy link
Contributor

selul commented Dec 18, 2024

@girishpanchal30 can you add some tests maybe for this? PHPUnit.

@girishpanchal30
Copy link
Contributor Author

@selul Yes sure!

@girishpanchal30
Copy link
Contributor Author

@girishpanchal30 can you add some tests maybe for this? PHPUnit.

@selul Sorry, we can only write the test case in the Pro version as it includes a new field for Pro users.
We can add PHPUnit later after releasing the Lite version.

@selul
Copy link
Contributor

selul commented Dec 18, 2024

we can add now, let me know what solutions do you have.

@girishpanchal30
Copy link
Contributor Author

@selul Ok, we can bypass the feedzy_is_pro() check during the import job by utilizing the defined( 'TI_UNIT_TESTING' ) condition.

For example:
( defined( 'TI_UNIT_TESTING' ) || feedzy_is_pro() ) && ! empty( $mark_duplicate_tag )

@girishpanchal30
Copy link
Contributor Author

@selul I've implemented PHPUnit test assertions to verify duplicate items and added e2e testing for upsell.

@girishpanchal30
Copy link
Contributor Author

@selul I have implemented the mock function for the PHPUnit test case. Please review it and let me know if any changes are needed.

@HardeepAsrani HardeepAsrani merged commit 3781401 into development Dec 28, 2024
8 checks passed
@HardeepAsrani HardeepAsrani deleted the feat/1006 branch December 28, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selul selul selul approved these changes

Assignees
No one assigned
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PRO] Improve the way we remove duplicates during the import
4 participants
@girishpanchal30 @pirate-bot @selul @HardeepAsrani