Merge pull request #132 from Codeception/fix-possibly-uninit-yiilogger

fix: fixes #131 yiilogger may not be initialized in _failed

Author: SamMousa

phpstan-baseline.neon

@@ -1698,12 +1698,6 @@ parameters:
 			count: 1
 			path: tests/cases/pageCacheHeaderAlreadySent/controllers/UserController.php
 
-		-
-			message: '#^Method app\\pageCacheHeaderAlreadySent\\controllers\\UserController\:\:behaviors\(\) return type has no value type specified in iterable type array\.$#'
-			identifier: missingType.iterableValue
-			count: 1
-			path: tests/cases/pageCacheHeaderAlreadySent/controllers/UserController.php
-
 		-
 			message: '#^Method PageCest\:\:testCache\(\) has no return type specified\.$#'
 			identifier: missingType.return

src/Codeception/Lib/Connector/Yii2.php

@@ -305,6 +305,7 @@ public function startApp(?\yii\log\Logger $logger = null): void
             self::MAIL_IGNORE => null// Do nothing
         };
 
+        // @phpstan-ignore argument.templateType
         $app = Yii::createObject($config);
         if (! $app instanceof \yii\base\Application) {
             throw new ModuleConfigException($this, "Failed to initialize Yii2 app");

src/Codeception/Module/Yii2.php

@@ -256,7 +256,7 @@ final class Yii2 extends Framework implements ActiveRecord, PartedModule
      */
     private array $server;
 
-    private Logger $yiiLogger;
+    private null|Logger $yiiLogger = null;
 
     private function getClient(): Yii2Connector
     {
@@ -292,7 +292,7 @@ protected function onReconfigure(): void
         $this->getClient()->resetApplication();
         $this->validateConfig();
         $this->configureClient($this->config);
-        $this->yiiLogger->getAndClearLog();
+        $this->yiiLogger?->getAndClearLog();
         $this->getClient()->startApp($this->yiiLogger);
     }
 
@@ -460,8 +460,8 @@ public function _after(TestInterface $test): void
      */
     public function _failed(TestInterface $test, $fail): void
     {
-        $log = $this->yiiLogger->getAndClearLog();
-        if ($log !== '') {
+        $log = $this->yiiLogger?->getAndClearLog();
+        if (isset($log) && $log !== '') {
             $test->getMetadata()->addReport('yii-log', $log);
         }