Support absolute file tool paths

Author: jahooma

common/src/templates/initial-agents-dir/types/tools.ts

@@ -353,7 +353,7 @@ export interface SpawnAgentsParams {
  * Replace strings in a file with new strings.
  */
 export interface StrReplaceParams {
-  /** The path to the file to edit. */
+  /** The path to the file to edit, either relative to the project root or an absolute path inside the project. */
   path: string
   /** Array of replacements to make. */
   replacements: {
@@ -411,7 +411,7 @@ export interface WebSearchParams {
  * Create or edit a file with the given content.
  */
 export interface WriteFileParams {
-  /** Path to the file relative to the **project root** */
+  /** Path to the file, either relative to the project root or an absolute path inside the project. */
   path: string
   /** What the change is intended to do in only one sentence. */
   instructions: string

common/src/tools/params/tool/str-replace.ts

@@ -28,7 +28,9 @@ const inputSchema = z
     path: z
       .string()
       .min(1, 'Path cannot be empty')
-      .describe(`The path to the file to edit.`),
+      .describe(
+        `The path to the file to edit, either relative to the project root or an absolute path inside the project.`,
+      ),
     replacements: z
       .preprocess(
         coerceToArray,

common/src/tools/params/tool/write-file.ts

@@ -12,7 +12,9 @@ const inputSchema = z
     path: z
       .string()
       .min(1, 'Path cannot be empty')
-      .describe(`Path to the file relative to the **project root**`),
+      .describe(
+        `Path to the file, either relative to the project root or an absolute path inside the project.`,
+      ),
     instructions: z
       .string()
       .describe('What the change is intended to do in only one sentence.'),

sdk/src/__tests__/change-file.test.ts

@@ -36,6 +36,37 @@ describe('changeFile', () => {
     )
   })
 
+  test('accepts absolute paths inside the project for string replacements', async () => {
+    const fs = createMockFs({
+      files: {
+        '/repo/src/file.ts': 'const value = 1\n',
+      },
+    })
+
+    const result = await changeFile({
+      parameters: {
+        type: 'patch',
+        path: '/repo/src/file.ts',
+        content: '@@ -1,1 +1,1 @@\n-const value = 1\n+const value = 2\n',
+      },
+      cwd: '/repo',
+      fs,
+    })
+
+    expect(result).toEqual([
+      {
+        type: 'json',
+        value: {
+          file: 'src/file.ts',
+          message: 'String replace applied successfully.',
+        },
+      },
+    ])
+    expect(await fs.readFile('/repo/src/file.ts', 'utf-8')).toBe(
+      'const value = 2\n',
+    )
+  })
+
   test('returns a simple success message for new file writes', async () => {
     const fs = createMockFs()
 
@@ -63,6 +94,58 @@ describe('changeFile', () => {
     )
   })
 
+  test('accepts absolute paths inside the project for file writes', async () => {
+    const fs = createMockFs()
+
+    const result = await changeFile({
+      parameters: {
+        type: 'file',
+        path: '/repo/src/file.ts',
+        content: 'const value = 1\n',
+      },
+      cwd: '/repo',
+      fs,
+    })
+
+    expect(result).toEqual([
+      {
+        type: 'json',
+        value: {
+          file: 'src/file.ts',
+          message: 'Created file successfully.',
+        },
+      },
+    ])
+    expect(await fs.readFile('/repo/src/file.ts', 'utf-8')).toBe(
+      'const value = 1\n',
+    )
+  })
+
+  test('accepts paths whose file names start with two dots inside the project', async () => {
+    const fs = createMockFs()
+
+    const result = await changeFile({
+      parameters: {
+        type: 'file',
+        path: '/repo/..config',
+        content: 'value = true\n',
+      },
+      cwd: '/repo',
+      fs,
+    })
+
+    expect(result).toEqual([
+      {
+        type: 'json',
+        value: {
+          file: '..config',
+          message: 'Created file successfully.',
+        },
+      },
+    ])
+    expect(await fs.readFile('/repo/..config', 'utf-8')).toBe('value = true\n')
+  })
+
   test('returns a simple success message for overwritten file writes', async () => {
     const fs = createMockFs({
       files: {
@@ -93,4 +176,20 @@ describe('changeFile', () => {
       'const value = 2\n',
     )
   })
+
+  test('rejects absolute paths outside the project', async () => {
+    const fs = createMockFs()
+
+    await expect(
+      changeFile({
+        parameters: {
+          type: 'file',
+          path: '/outside/file.ts',
+          content: 'const value = 1\n',
+        },
+        cwd: '/repo',
+        fs,
+      }),
+    ).rejects.toThrow('file path is outside the project directory')
+  })
 })

sdk/src/__tests__/path-utils.test.ts

@@ -0,0 +1,34 @@
+import { describe, expect, test } from 'bun:test'
+
+import { resolveFilePathWithinProject } from '../tools/path-utils'
+
+describe('resolveFilePathWithinProject', () => {
+  test('normalizes relative paths to full and project-relative paths', () => {
+    expect(resolveFilePathWithinProject('/repo', 'src/file.ts')).toEqual({
+      fullPath: '/repo/src/file.ts',
+      relativePath: 'src/file.ts',
+    })
+  })
+
+  test('normalizes absolute paths inside the project', () => {
+    expect(resolveFilePathWithinProject('/repo', '/repo/src/file.ts')).toEqual({
+      fullPath: '/repo/src/file.ts',
+      relativePath: 'src/file.ts',
+    })
+  })
+
+  test('allows file names that start with two dots inside the project', () => {
+    expect(resolveFilePathWithinProject('/repo', '/repo/..config')).toEqual({
+      fullPath: '/repo/..config',
+      relativePath: '..config',
+    })
+  })
+
+  test('rejects paths outside the project', () => {
+    expect(resolveFilePathWithinProject('/repo', '../outside.ts')).toBeNull()
+    expect(resolveFilePathWithinProject('/repo', '/outside.ts')).toBeNull()
+    expect(
+      resolveFilePathWithinProject('/repo', '/repo-sibling/file.ts'),
+    ).toBeNull()
+  })
+})

sdk/src/__tests__/read-files.test.ts

@@ -11,13 +11,11 @@ import {
   spyOn,
 } from 'bun:test'
 
-
 import { getFiles } from '../tools/read-files'
 
 import type { CodebuffFileSystem } from '@codebuff/common/types/filesystem'
 import type { PathLike } from 'node:fs'
 
-
 // Helper to create a mock filesystem
 function createMockFs(config: {
   files?: Record<string, { content: string; size?: number }>
@@ -75,9 +73,10 @@ describe('getFiles', () => {
 
   beforeEach(() => {
     // Default: no files are ignored
-    isFileIgnoredSpy = spyOn(projectFileTree, 'isFileIgnored').mockResolvedValue(
-      false,
-    )
+    isFileIgnoredSpy = spyOn(
+      projectFileTree,
+      'isFileIgnored',
+    ).mockResolvedValue(false)
   })
 
   afterEach(() => {
@@ -320,9 +319,7 @@ describe('getFiles', () => {
 
     test('should handle mix of ignored and non-ignored files', async () => {
       // First call returns false (not ignored), second returns true (ignored)
-      isFileIgnoredSpy
-        .mockResolvedValueOnce(false)
-        .mockResolvedValueOnce(true)
+      isFileIgnoredSpy.mockResolvedValueOnce(false).mockResolvedValueOnce(true)
 
       const mockFs = createMockFs({
         files: {
@@ -393,7 +390,10 @@ describe('getFiles', () => {
       const mockFs = createMockFs({
         files: {},
         errors: {
-          '/project/broken.ts': { code: 'EACCES', message: 'Permission denied' },
+          '/project/broken.ts': {
+            code: 'EACCES',
+            message: 'Permission denied',
+          },
         },
       })
 
@@ -423,6 +423,24 @@ describe('getFiles', () => {
 
       expect(result['src/index.ts']).toBe('content')
     })
+
+    test('should reject absolute paths in sibling directories with matching prefixes', async () => {
+      const mockFs = createMockFs({
+        files: {
+          '/project-other/src/index.ts': { content: 'outside' },
+        },
+      })
+
+      const result = await getFiles({
+        filePaths: ['/project-other/src/index.ts'],
+        cwd: '/project',
+        fs: mockFs,
+      })
+
+      expect(result['/project-other/src/index.ts']).toBe(
+        FILE_READ_STATUS.OUTSIDE_PROJECT,
+      )
+    })
   })
 
   describe('fileFilter option', () => {