Fix JenkinsAPI#changeJenkinsPassword, Add Maven settings.xml Configuration

Author: gmitch215

src/main/kotlin/io/codemc/api/jenkins/jenkins.kt

@@ -4,10 +4,12 @@ package io.codemc.api.jenkins
 
 import com.cdancy.jenkins.rest.JenkinsClient
 import io.codemc.api.*
+import io.codemc.api.nexus.isSuccess
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.runBlocking
 import org.jetbrains.annotations.VisibleForTesting
 import java.net.http.HttpRequest
+import javax.xml.parsers.DocumentBuilderFactory
 
 /**
  * The [JenkinsConfig] instance.
@@ -59,7 +61,7 @@ const val NEXUS_CREDENTIALS_ID = "nexus-repository"
  */
 const val NEXUS_CREDENTIALS_DESCRIPTION = "Your Nexus Login Details"
 
-internal suspend fun createCredentials(username: String, password: String): Boolean {
+internal suspend fun setCredentials(username: String, password: String): Boolean {
     // Create Credentials Domain
     val checkDomain = req("${jenkinsConfig.url}/job/$username/credentials/store/folder/domain/Services/config.xml") {
         GET()
@@ -76,7 +78,7 @@ internal suspend fun createCredentials(username: String, password: String): Bool
             header("Content-Type", "application/xml")
         }
 
-        if (domain.statusCode() != 200) return false
+        if (!domain.statusCode().isSuccess) return false
     }
 
     // Create Credentials Store
@@ -93,8 +95,18 @@ internal suspend fun createCredentials(username: String, password: String): Bool
         header("Content-Type", "application/xml")
     }
 
-    // Either successful or already exists
-    return store.statusCode() == 200 || store.statusCode() == 409
+    // Update if Already Exists
+    if (store.statusCode() == 409) {
+        val update = req("${jenkinsConfig.url}/job/$username/credentials/store/folder/domain/Services/credential/$NEXUS_CREDENTIALS_ID/config.xml") {
+            POST(HttpRequest.BodyPublishers.ofString(storeConfig))
+
+            header("Authorization", "Basic ${client.authValue()}")
+            header("Content-Type", "application/xml")
+        }
+
+        return update.statusCode().isSuccess
+    } else
+        return store.statusCode().isSuccess
 }
 
 /**
@@ -118,18 +130,44 @@ fun checkCredentials(username: String, password: String) = runBlocking(Dispatche
     }
 
     if (checkDomain.statusCode() == 404 || checkStore.statusCode() == 404) {
-        createCredentials(username, password)
+        setCredentials(username, password)
     }
 }
 
+/**
+ * Checks the user `config.xml` present on the Jenkins CI.
+ * @param username The username of the user.
+ * @return `true` if the user configuration was changed, `false` otherwise.
+ */
+fun checkUserConfig(username: String) = runBlocking(Dispatchers.IO) {
+    val xml = client.api().jobsApi().config("/", username)
+    var changed = false
+
+    val factory = DocumentBuilderFactory.newInstance()
+    val builder = factory.newDocumentBuilder()
+    val doc = builder.parse(xml.byteInputStream())
+
+    // Check Maven Settings/
+    if (!xml.contains("<id>nexus-login</id>")) {
+        val settings = RESOURCE_CACHE[MAVEN_SETTINGS_XML] ?: return@runBlocking
+        val configs = doc.getElementsByTagName("configs").item(0)
+
+        configs.appendChild(builder.parse(settings.byteInputStream()).documentElement)
+        changed = true
+    }
+
+    if (changed)
+        client.api().jobsApi().config("/", username, doc.textContent)
+}
+
 /**
  * Changes the Jenkins password for a user.
  * @param username The username of the user.
  * @param newPassword The new password.
  * @return `true` if the password was changed, `false` otherwise.
  */
 fun changeJenkinsPassword(username: String, newPassword: String): Boolean = runBlocking(Dispatchers.IO) {
-    return@runBlocking createCredentials(username, newPassword)
+    return@runBlocking setCredentials(username, newPassword)
 }
 
 /**
@@ -152,7 +190,7 @@ fun createJenkinsUser(username: String, password: String): Boolean = runBlocking
 
     if (!status.value()) return@runBlocking false
 
-    return@runBlocking createCredentials(username, password)
+    return@runBlocking setCredentials(username, password)
 }
 
 /**

src/main/kotlin/io/codemc/api/resources.kt

@@ -31,6 +31,11 @@ const val CREDENTIALS = "credentials"
  */
 const val CREDENTIALS_DOMAIN = "credentials-domain"
 
+/**
+ * The ID of the maven settings template for jenkins credentials.
+ */
+const val MAVEN_SETTINGS_XML = "maven-settings"
+
 // Fields
 
 /**
@@ -42,7 +47,8 @@ private val resources = mapOf(
     "/templates/jenkins/job-maven.xml" to JOB_MAVEN,
     "/templates/jenkins/user-config.xml" to USER_CONFIG,
     "/templates/jenkins/credentials.xml" to CREDENTIALS,
-    "/templates/jenkins/credentials-domain.xml" to CREDENTIALS_DOMAIN
+    "/templates/jenkins/credentials-domain.xml" to CREDENTIALS_DOMAIN,
+    "/templates/jenkins/maven/settings.xml" to MAVEN_SETTINGS_XML
 )
 
 /**

src/main/resources/templates/jenkins/maven/settings.xml

@@ -0,0 +1,17 @@
+<org.jenkinsci.plugins.configfiles.maven.MavenSettingsConfig>
+    <id>nexus-login</id>
+    <name>Nexus Login Details</name>
+    <comment>Maven Credentials for your Nexus Repository</comment>
+    <content>&lt;settings&gt;
+  &lt;servers&gt;
+    &lt;server&gt;
+      &lt;id&gt;${env.JENKINS_USERNAME}&lt;/id&gt;
+      &lt;username&gt;${env.JENKINS_USERNAME}&lt;/username&gt;
+      &lt;password&gt;${env.JENKINS_PASSWORD}&lt;/password&gt;
+    &lt;/server&gt;
+  &lt;/servers&gt;
+&lt;/settings&gt;</content>
+    <providerId>org.jenkinsci.plugins.configfiles.maven.MavenSettingsConfig</providerId>
+    <serverCredentialMappings/>
+    <isReplaceAll>true</isReplaceAll>
+</org.jenkinsci.plugins.configfiles.maven.MavenSettingsConfig>

src/test/kotlin/io/codemc/api/jenkins/TestJenkins.kt

@@ -28,12 +28,16 @@ class TestJenkins {
     fun testCreateJenkinsUser() {
         val u1 = "test"
         assertTrue(createJenkinsUser(u1, "test_password"))
+        checkUserConfig(u1)
+
         assertTrue(getJenkinsUser(u1).isNotEmpty())
         assertTrue(deleteUser(u1))
         assertTrue(getJenkinsUser(u1).isEmpty())
 
         val u2 = "MyPlayer123"
         assertTrue(createJenkinsUser(u2, "MyPassword456"))
+        checkUserConfig(u2)
+
         assertTrue(getJenkinsUser(u2).isNotEmpty())
         assertTrue(deleteUser(u2))
         assertTrue(getJenkinsUser(u2).isEmpty())