Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change maxCount to firstQuartileCount in plastics.json #36

Open
DainialPadraig opened this issue Dec 29, 2020 · 0 comments
Open

Change maxCount to firstQuartileCount in plastics.json #36

DainialPadraig opened this issue Dec 29, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@DainialPadraig
Copy link
Contributor

The maxCount (rank 1) value in the plastics JSON file needs to be changed to firstQuartileCount with the value for the rank 3 country instead. This will make calculating the mission count more straight-forward, since the mission count can be calculated between the medianCount and the firstQuartileCount.

The potential downside of this change is that, either the data file will need to be modified again or logic will need to be added to choose a different upper bound for the rand() function (like the rank 2 count), if the first quartile value makes the game too easy.

@DainialPadraig DainialPadraig added the bug Something isn't working label Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant