Note Issue With Glass Here

Author: thecoolwinter

CodeEdit/Features/Editor/Views/EditorAreaView.swift

@@ -18,18 +18,6 @@ struct EditorAreaView: View {
 
     @AppSettings(\.general.dimEditorsWithoutFocus)
     var dimEditorsWithoutFocus
-    
-    @AppSettings(\.theme.useThemeBackground)
-    var useThemeBackground
-
-    private var backgroundColor: NSColor {
-        let fallback = NSColor.textBackgroundColor
-        return if useThemeBackground {
-            ThemeModel.shared.selectedTheme?.editor.background.nsColor ?? fallback
-        } else {
-            fallback
-        }
-    }
 
     @ObservedObject var editor: Editor
 
@@ -152,6 +140,34 @@ struct EditorAreaView: View {
                 .if(.tahoe) {
                     // FB20047271: Glass toolbar effect ignores floating scroll view views.
                     // https://openradar.appspot.com/radar?id=EhAKBVJhZGFyEICAgKbGmesJ
+
+                    // FB20191516: Can't disable backgrounded liquid glass tint
+                    // https://openradar.appspot.com/radar?id=EhAKBVJhZGFyEICAgLqTk-4J
+                    // Tracking Issue: #2191
+                    // Add this to the top:
+                    // ```
+                    // @AppSettings(\.theme.useThemeBackground)
+                    // var useThemeBackground
+                    //
+                    // private var backgroundColor: NSColor {
+                    //     let fallback = NSColor.textBackgroundColor
+                    //     return if useThemeBackground {
+                    //         ThemeModel.shared.selectedTheme?.editor.background.nsColor ?? fallback
+                    //     } else {
+                    //         fallback
+                    //     }
+                    // }
+                    // ```
+                    // And use this:
+                    // ```
+                    // $0.background(
+                    //    Rectangle().fill(.clear)
+                    //        .glassEffect(.regular.tint(Color(backgroundColor))
+                    //        .ignoresSafeArea(.all)
+                    // )
+                    // ```
+                    // When we can figure out how to disable the 'not focused' glass effect.
+
                     $0.background(EffectView(.headerView).ignoresSafeArea(.all))
                 } else: {
                     $0.background(EffectView(.headerView))