Commit f52062e
authored
Fixed editor tabs from being non-interactive (#2004)
> [!IMPORTANT]
> This is a temporary fix for a bug introduced in the latest version of macOS. This should be periodically checked to see if it is fixed and when it is, revert this fix.
### Description
Restored editor tabs interactivity. It seems like the topmost item loses interactivity so we fix this by placing a 1pt Rectangle at the top, effectively tricking the system. We then apply negative top padding inside to correct spacing issues.
### Checklist
<!--- Add things that are not yet implemented above -->
- [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)
- [x] The issues this PR addresses are related to each other
- [x] My changes generate no new warnings
- [x] My code builds and runs on my machine
- [x] My changes are all related to the related issue above
- [x] I documented my code1 parent 1f6c33a commit f52062e
File tree
3 files changed
+33
-22
lines changed- CodeEdit/Features/Editor
- TabBar
- Tabs/Tab
- Views
- Views
3 files changed
+33
-22
lines changedLines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
226 | 226 | | |
227 | 227 | | |
228 | 228 | | |
229 | | - | |
230 | | - | |
231 | 229 | | |
232 | 230 | | |
233 | 231 | | |
| |||
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| 19 | + | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
| 25 | + | |
23 | 26 | | |
24 | | - | |
| 27 | + | |
| 28 | + | |
25 | 29 | | |
26 | 30 | | |
27 | 31 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
111 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
112 | 124 | | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | 125 | | |
| 126 | + | |
| 127 | + | |
117 | 128 | | |
118 | | - | |
119 | | - | |
120 | 129 | | |
121 | 130 | | |
122 | 131 | | |
| |||
0 commit comments