Fix SwiftLint errors by splitting up NotificationManager

Author: austincondiff

CodeEdit.xcodeproj/project.pbxproj

@@ -558,6 +558,8 @@
 		B65B10FE2B08B07D002852CF /* SourceControlNavigatorChangesList.swift in Sources */ = {isa = PBXBuildFile; fileRef = B65B10FD2B08B07D002852CF /* SourceControlNavigatorChangesList.swift */; };
 		B65B11012B09D5D4002852CF /* GitClient+Pull.swift in Sources */ = {isa = PBXBuildFile; fileRef = B65B11002B09D5D4002852CF /* GitClient+Pull.swift */; };
 		B65B11042B09DB1C002852CF /* GitClient+Fetch.swift in Sources */ = {isa = PBXBuildFile; fileRef = B65B11032B09DB1C002852CF /* GitClient+Fetch.swift */; };
+		B66460592D600E9500EC1411 /* NotificationManager+Delegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = B66460572D600E9500EC1411 /* NotificationManager+Delegate.swift */; };
+		B664605A2D600E9500EC1411 /* NotificationManager+System.swift in Sources */ = {isa = PBXBuildFile; fileRef = B66460582D600E9500EC1411 /* NotificationManager+System.swift */; };
 		B664C3B02B965F6C00816B4E /* NavigationSettings.swift in Sources */ = {isa = PBXBuildFile; fileRef = B664C3AF2B965F6C00816B4E /* NavigationSettings.swift */; };
 		B664C3B32B96634F00816B4E /* NavigationSettingsView.swift in Sources */ = {isa = PBXBuildFile; fileRef = B664C3B22B96634F00816B4E /* NavigationSettingsView.swift */; };
 		B66A4E4529C8E86D004573B4 /* CommandsFixes.swift in Sources */ = {isa = PBXBuildFile; fileRef = B66A4E4429C8E86D004573B4 /* CommandsFixes.swift */; };
@@ -1253,6 +1255,8 @@
 		B65B10FD2B08B07D002852CF /* SourceControlNavigatorChangesList.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SourceControlNavigatorChangesList.swift; sourceTree = "<group>"; };
 		B65B11002B09D5D4002852CF /* GitClient+Pull.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "GitClient+Pull.swift"; sourceTree = "<group>"; };
 		B65B11032B09DB1C002852CF /* GitClient+Fetch.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "GitClient+Fetch.swift"; sourceTree = "<group>"; };
+		B66460572D600E9500EC1411 /* NotificationManager+Delegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "NotificationManager+Delegate.swift"; sourceTree = "<group>"; };
+		B66460582D600E9500EC1411 /* NotificationManager+System.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "NotificationManager+System.swift"; sourceTree = "<group>"; };
 		B664C3AF2B965F6C00816B4E /* NavigationSettings.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NavigationSettings.swift; sourceTree = "<group>"; };
 		B664C3B22B96634F00816B4E /* NavigationSettingsView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NavigationSettingsView.swift; sourceTree = "<group>"; };
 		B66A4E4429C8E86D004573B4 /* CommandsFixes.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CommandsFixes.swift; sourceTree = "<group>"; };
@@ -3583,6 +3587,8 @@
 				B68DE5D82D5A61E5009A43EF /* Models */,
 				B68DE5DC2D5A61E5009A43EF /* Views */,
 				B68DE5DD2D5A61E5009A43EF /* NotificationManager.swift */,
+				B66460572D600E9500EC1411 /* NotificationManager+Delegate.swift */,
+				B66460582D600E9500EC1411 /* NotificationManager+System.swift */,
 			);
 			path = Notifications;
 			sourceTree = "<group>";
@@ -4525,6 +4531,8 @@
 				B6A43C5D29FC4AF00027E0E0 /* CreateSSHKeyView.swift in Sources */,
 				B6EA200229DB7F81001BF195 /* View+ConstrainHeightToWindow.swift in Sources */,
 				66F370342BEE537B00D3B823 /* NonTextFileView.swift in Sources */,
+				B66460592D600E9500EC1411 /* NotificationManager+Delegate.swift in Sources */,
+				B664605A2D600E9500EC1411 /* NotificationManager+System.swift in Sources */,
 				613899B72B6E702F00A5CAF6 /* String+LengthOfMatchingPrefix.swift in Sources */,
 				6C48D8F42972DB1A00D6D205 /* Env+Window.swift in Sources */,
 				6C5FDF7A29E6160000BC08C0 /* AppSettings.swift in Sources */,

CodeEdit/Features/Notifications/NotificationManager+Delegate.swift

@@ -0,0 +1,25 @@
+import UserNotifications
+
+extension NotificationManager: UNUserNotificationCenterDelegate {
+    func userNotificationCenter(
+        _ center: UNUserNotificationCenter,
+        didReceive response: UNNotificationResponse,
+        withCompletionHandler completionHandler: @escaping () -> Void
+    ) {
+        if let id = response.notification.request.content.userInfo["id"] as? String {
+            DispatchQueue.main.async {
+                self.handleSystemNotificationResponse(id: id)
+            }
+        }
+        completionHandler()
+    }
+
+    func userNotificationCenter(
+        _ center: UNUserNotificationCenter,
+        willPresent notification: UNNotification,
+        withCompletionHandler completionHandler: @escaping (UNNotificationPresentationOptions) -> Void
+    ) {
+        // Don't show system notifications when app is active
+        completionHandler([])
+    }
+} 

CodeEdit/Features/Notifications/NotificationManager+System.swift

@@ -0,0 +1,28 @@
+import SwiftUI
+
+extension NotificationManager {
+    /// Shows a notification in macOS Notification Center when app is in background
+    func showSystemNotification(_ notification: CENotification) {
+        let content = UNMutableNotificationContent()
+        content.title = notification.title
+        content.body = notification.description
+        content.userInfo = ["id": notification.id.uuidString]
+
+        let request = UNNotificationRequest(
+            identifier: notification.id.uuidString,
+            content: content,
+            trigger: nil
+        )
+
+        UNUserNotificationCenter.current().add(request)
+    }
+
+    /// Handles response from system notification
+    func handleSystemNotificationResponse(id: String) {
+        if let uuid = UUID(uuidString: id),
+           let notification = notifications.first(where: { $0.id == uuid }) {
+            notification.action()
+            dismissNotification(notification)
+        }
+    }
+} 

CodeEdit/Features/Notifications/NotificationManager.swift

@@ -107,11 +107,6 @@ final class NotificationManager: NSObject, ObservableObject {
         notifications.filter { !$0.isRead }.count
     }
 
-    /// Whether there are currently notifications being displayed in the overlay
-    var hasActiveNotification: Bool {
-        !activeNotifications.isEmpty
-    }
-
     /// Posts a new notification
     /// - Parameters:
     ///   - iconSymbol: SF Symbol or CodeEditSymbol name for the notification icon
@@ -230,22 +225,6 @@ final class NotificationManager: NSObject, ObservableObject {
         }
     }
 
-    /// Shows a notification in macOS Notification Center when app is in background
-    private func showSystemNotification(_ notification: CENotification) {
-        let content = UNMutableNotificationContent()
-        content.title = notification.title
-        content.body = notification.description
-        content.userInfo = ["id": notification.id.uuidString]
-
-        let request = UNNotificationRequest(
-            identifier: notification.id.uuidString,
-            content: content,
-            trigger: nil
-        )
-
-        UNUserNotificationCenter.current().add(request)
-    }
-
     /// Shows a notification in the app's overlay UI
     private func showTemporaryNotification(_ notification: CENotification) {
         withAnimation(.easeInOut(duration: 0.3)) {
@@ -350,16 +329,6 @@ final class NotificationManager: NSObject, ObservableObject {
         }
     }
 
-    /// Handles response from system notification
-    /// - Parameter id: ID of the notification that was interacted with
-    func handleSystemNotificationResponse(id: String) {
-        if let uuid = UUID(uuidString: id),
-           let notification = notifications.first(where: { $0.id == uuid }) {
-            notification.action()
-            dismissNotification(notification)
-        }
-    }
-
     /// Toggles visibility of notifications in the overlay
     func toggleNotificationsVisibility() {
         withAnimation(.easeInOut(duration: 0.3)) {
@@ -378,29 +347,3 @@ final class NotificationManager: NSObject, ObservableObject {
         }
     }
 }
-
-// MARK: - UNUserNotificationCenterDelegate
-
-extension NotificationManager: UNUserNotificationCenterDelegate {
-    func userNotificationCenter(
-        _ center: UNUserNotificationCenter,
-        didReceive response: UNNotificationResponse,
-        withCompletionHandler completionHandler: @escaping () -> Void
-    ) {
-        if let id = response.notification.request.content.userInfo["id"] as? String {
-            DispatchQueue.main.async {
-                self.handleSystemNotificationResponse(id: id)
-            }
-        }
-        completionHandler()
-    }
-
-    func userNotificationCenter(
-        _ center: UNUserNotificationCenter,
-        willPresent notification: UNNotification,
-        withCompletionHandler completionHandler: @escaping (UNNotificationPresentationOptions) -> Void
-    ) {
-        // Don't show system notifications when app is active
-        completionHandler([])
-    }
-}