Improve notification handling and workspace panel behavior

- Add system notification action button that, when clicked, focuses CodeEdit, runs the action, and dismisses the corresponding CodeEdit notification.
- Dismissing a CodeEdit notification now also dismisses its corresponding system notification, and vice versa.
- The notification panel in a workspace now closes when clicking outside of it, behaving like other menus.
- Refactored notification state management: Moved display-related state from `NotificationService` to a dedicated view model to ensure notification panels remain independent across workspaces.

Author: austincondiff

CodeEdit.xcodeproj/project.pbxproj

@@ -595,6 +595,7 @@
 		B6966A342C34996B00259C2D /* SourceControlManager+GitClient.swift in Sources */ = {isa = PBXBuildFile; fileRef = B6966A332C34996B00259C2D /* SourceControlManager+GitClient.swift */; };
 		B696A7E62CFE20C40048CFE1 /* FeatureIcon.swift in Sources */ = {isa = PBXBuildFile; fileRef = B696A7E52CFE20C40048CFE1 /* FeatureIcon.swift */; };
 		B697937A29FF5668002027EC /* AccountsSettingsAccountLink.swift in Sources */ = {isa = PBXBuildFile; fileRef = B697937929FF5668002027EC /* AccountsSettingsAccountLink.swift */; };
+		B69970322D63E5C700BB132D /* NotificationOverlayViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = B69970302D63E5C700BB132D /* NotificationOverlayViewModel.swift */; };
 		B69BFDC72B0686910050D9A6 /* GitClient+Initiate.swift in Sources */ = {isa = PBXBuildFile; fileRef = B69BFDC62B0686910050D9A6 /* GitClient+Initiate.swift */; };
 		B69D3EDE2C5E85A2005CF43A /* StopTaskToolbarButton.swift in Sources */ = {isa = PBXBuildFile; fileRef = B69D3EDD2C5E85A2005CF43A /* StopTaskToolbarButton.swift */; };
 		B69D3EE12C5F5357005CF43A /* TaskView.swift in Sources */ = {isa = PBXBuildFile; fileRef = B69D3EE02C5F5357005CF43A /* TaskView.swift */; };
@@ -1292,6 +1293,7 @@
 		B6966A332C34996B00259C2D /* SourceControlManager+GitClient.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "SourceControlManager+GitClient.swift"; sourceTree = "<group>"; };
 		B696A7E52CFE20C40048CFE1 /* FeatureIcon.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FeatureIcon.swift; sourceTree = "<group>"; };
 		B697937929FF5668002027EC /* AccountsSettingsAccountLink.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AccountsSettingsAccountLink.swift; sourceTree = "<group>"; };
+		B69970302D63E5C700BB132D /* NotificationOverlayViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NotificationOverlayViewModel.swift; sourceTree = "<group>"; };
 		B69BFDC62B0686910050D9A6 /* GitClient+Initiate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "GitClient+Initiate.swift"; sourceTree = "<group>"; };
 		B69D3EDD2C5E85A2005CF43A /* StopTaskToolbarButton.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = StopTaskToolbarButton.swift; sourceTree = "<group>"; };
 		B69D3EE02C5F5357005CF43A /* TaskView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TaskView.swift; sourceTree = "<group>"; };
@@ -3585,6 +3587,7 @@
 			isa = PBXGroup;
 			children = (
 				B68DE5D82D5A61E5009A43EF /* Models */,
+				B69970312D63E5C700BB132D /* ViewModels */,
 				B68DE5DC2D5A61E5009A43EF /* Views */,
 				B68DE5DD2D5A61E5009A43EF /* NotificationManager.swift */,
 				B66460572D600E9500EC1411 /* NotificationManager+Delegate.swift */,
@@ -3609,6 +3612,14 @@
 			path = Views;
 			sourceTree = "<group>";
 		};
+		B69970312D63E5C700BB132D /* ViewModels */ = {
+			isa = PBXGroup;
+			children = (
+				B69970302D63E5C700BB132D /* NotificationOverlayViewModel.swift */,
+			);
+			path = ViewModels;
+			sourceTree = "<group>";
+		};
 		B69D3EDC2C5E856F005CF43A /* Views */ = {
 			isa = PBXGroup;
 			children = (
@@ -4232,6 +4243,7 @@
 				B6B2D7A12CE8797B00379967 /* GitConfigExtensions.swift in Sources */,
 				587B9E7329301D8F00AC7927 /* GitRouter.swift in Sources */,
 				6C2C156129B4F52F00EA60A5 /* SplitViewModifiers.swift in Sources */,
+				B69970322D63E5C700BB132D /* NotificationOverlayViewModel.swift in Sources */,
 				B68DE5E52D5A7988009A43EF /* NotificationOverlayView.swift in Sources */,
 				61A53A812B4449F00093BF8A /* WorkspaceDocument+Index.swift in Sources */,
 				66AF6CE22BF17CC300D83C9D /* StatusBarViewModel.swift in Sources */,

CodeEdit/AppDelegate.swift

@@ -26,6 +26,21 @@ final class AppDelegate: NSObject, NSApplicationDelegate, ObservableObject {
 
         NSApp.closeWindow(.welcome, .about)
 
+        // Add test notification
+        DispatchQueue.main.asyncAfter(deadline: .now() + 5.0) {
+            NotificationManager.shared.post(
+                iconText: "👋",
+                iconTextColor: .white,
+                iconColor: .indigo,
+                title: "Welcome to CodeEdit",
+                description: "This is a test notification to demonstrate the notification system.",
+                actionButtonTitle: "Learn More...",
+                action: {
+                    print("Action button clicked!")
+                }
+            )
+        }
+
         DispatchQueue.main.async {
             var needToHandleOpen = true
 

CodeEdit/Features/Documents/Controllers/CodeEditWindowController+Toolbar.swift

@@ -179,7 +179,11 @@ extension CodeEditWindowController {
             return toolbarItem
         case .notificationItem:
             let toolbarItem = NSToolbarItem(itemIdentifier: .notificationItem)
-            let view = NSHostingView(rootView: NotificationToolbarItem())
+            guard let workspace = workspace else { return nil }
+            let view = NSHostingView(
+                rootView: NotificationToolbarItem()
+                    .environmentObject(workspace)
+            )
             toolbarItem.view = view
             return toolbarItem
         default:

CodeEdit/Features/Documents/WorkspaceDocument/WorkspaceDocument.swift

@@ -43,11 +43,26 @@ final class WorkspaceDocument: NSDocument, ObservableObject, NSToolbarDelegate {
     var workspaceSettingsManager: CEWorkspaceSettings?
     var taskNotificationHandler: TaskNotificationHandler = TaskNotificationHandler()
 
+    @Published var notificationOverlay = NotificationOverlayViewModel()
+    private var notificationOverlaySubscription: AnyCancellable?
+
     private var cancellables = Set<AnyCancellable>()
 
+    override init() {
+        super.init()
+
+        // Observe changes to notification overlay
+        notificationOverlaySubscription = notificationOverlay.objectWillChange
+            .receive(on: DispatchQueue.main)
+            .sink { [weak self] _ in
+                self?.objectWillChange.send()
+            }
+    }
+
     deinit {
         cancellables.forEach { $0.cancel() }
         NotificationCenter.default.removeObserver(self)
+        notificationOverlaySubscription?.cancel()
     }
 
     func getFromWorkspaceState(_ key: WorkspaceStateKey) -> Any? {

CodeEdit/Features/InspectorArea/FileInspector/FileInspectorView.swift

@@ -59,6 +59,71 @@ struct FileInspectorView: View {
                         widthOptions
                         wrapLinesToggle
                     }
+                    Section("Test Notifications") {
+                        Button("Add Notification") {
+                            let (iconSymbol, iconColor) = randomSymbolAndColor()
+                            NotificationManager.shared.post(
+                                iconSymbol: iconSymbol,
+                                iconColor: iconColor,
+                                title: "Test Notification",
+                                description: "This is a test notification.",
+                                actionButtonTitle: "Action",
+                                action: {
+                                    print("Test notification action triggered")
+                                }
+                            )
+                        }
+                        Button("Add Sticky Notification") {
+                            NotificationManager.shared.post(
+                                iconSymbol: "pin.fill",
+                                iconColor: .orange,
+                                title: "Sticky Notification",
+                                description: "This notification will stay until dismissed.",
+                                actionButtonTitle: "Acknowledge",
+                                action: {
+                                    print("Sticky notification acknowledged")
+                                },
+                                isSticky: true
+                            )
+                        }
+                        Button("Add Image Notification") {
+                            NotificationManager.shared.post(
+                                iconImage: randomImage(),
+                                title: "Test Notification with Image",
+                                description: "This is a test notification with a custom image.",
+                                actionButtonTitle: "Action",
+                                action: {
+                                    print("Test notification action triggered")
+                                }
+                            )
+                        }
+                        Button("Add Text Notification") {
+                            NotificationManager.shared.post(
+                                iconText: randomLetter(),
+                                iconTextColor: .white,
+                                iconColor: randomColor(),
+                                title: "Text Notification",
+                                description: "This is a test notification with text.",
+                                actionButtonTitle: "Acknowledge",
+                                action: {
+                                    print("Test notification action triggered")
+                                }
+                            )
+                        }
+                        Button("Add Emoji Notification") {
+                            NotificationManager.shared.post(
+                                iconText: randomEmoji(),
+                                iconTextColor: .white,
+                                iconColor: randomColor(),
+                                title: "Emoji Notification",
+                                description: "This is a test notification with an emoji.",
+                                actionButtonTitle: "Acknowledge",
+                                action: {
+                                    print("Test notification action triggered")
+                                }
+                            )
+                        }
+                    }
                 }
             } else {
                 NoSelectionInspectorView()
@@ -81,6 +146,62 @@ struct FileInspectorView: View {
         }
     }
 
+    func randomColor() -> Color {
+        let colors: [Color] = [
+            .red, .orange, .yellow, .green, .mint, .cyan,
+            .teal, .blue, .indigo, .purple, .pink, .gray
+        ]
+        return colors.randomElement() ?? .black
+    }
+
+    func randomSymbolAndColor() -> (String, Color) {
+        let symbols: [(String, Color)] = [
+            ("bell.fill", .red),
+            ("bell.badge.fill", .red),
+            ("exclamationmark.triangle.fill", .orange),
+            ("info.circle.fill", .blue),
+            ("checkmark.seal.fill", .green),
+            ("xmark.octagon.fill", .red),
+            ("bubble.left.fill", .teal),
+            ("envelope.fill", .blue),
+            ("phone.fill", .green),
+            ("megaphone.fill", .pink),
+            ("clock.fill", .gray),
+            ("calendar", .red),
+            ("flag.fill", .green),
+            ("bookmark.fill", .orange),
+            ("bolt.fill", .indigo),
+            ("shield.lefthalf.fill", .red),
+            ("gift.fill", .purple),
+            ("heart.fill", .pink),
+            ("star.fill", .orange),
+            ("curlybraces", .cyan),
+        ]
+        return symbols.randomElement() ?? ("bell.fill", .red)
+    }
+
+    func randomEmoji() -> String {
+        let emoji: [String] = [
+            "🔔", "🚨", "⚠️", "👋", "😍", "😎", "😘", "😜", "😝", "😀", "😁",
+            "😂", "🤣", "😃", "😄", "😅", "😆", "😇", "😉", "😊", "😋", "😌"
+        ]
+        return emoji.randomElement() ?? "🔔"
+    }
+
+    func randomImage() -> Image {
+        let images: [Image] = [
+            Image("GitHubIcon"),
+            Image("BitBucketIcon"),
+            Image("GitLabIcon")
+        ]
+        return images.randomElement() ?? Image("GitHubIcon")
+    }
+
+    func randomLetter() -> String {
+        let letters = "ABCDEFGHIJKLMNOPQRSTUVWXYZ".map { String($0) }
+        return letters.randomElement() ?? "A"
+    }
+
     @ViewBuilder private var fileNameField: some View {
         @State var isValid: Bool = true
 

CodeEdit/Features/Notifications/NotificationManager+Delegate.swift

@@ -5,6 +5,7 @@
 //  Created by Austin Condiff on 2/14/24.
 //
 
+import AppKit
 import UserNotifications
 
 extension NotificationManager: UNUserNotificationCenterDelegate {
@@ -13,11 +14,24 @@ extension NotificationManager: UNUserNotificationCenterDelegate {
         didReceive response: UNNotificationResponse,
         withCompletionHandler completionHandler: @escaping () -> Void
     ) {
-        if let id = response.notification.request.content.userInfo["id"] as? String {
-            DispatchQueue.main.async {
-                self.handleSystemNotificationResponse(id: id)
+        if let notification = notifications.first(where: {
+            $0.id.uuidString == response.notification.request.identifier
+        }) {
+            // Focus CodeEdit and run action if action button was clicked
+            if response.actionIdentifier == "ACTION_BUTTON" ||
+               response.actionIdentifier == UNNotificationDefaultActionIdentifier {
+                NSApp.activate(ignoringOtherApps: true)
+                notification.action()
+            }
+
+            // Remove the notification for both action and dismiss
+            if response.actionIdentifier == "ACTION_BUTTON" ||
+               response.actionIdentifier == UNNotificationDefaultActionIdentifier ||
+               response.actionIdentifier == UNNotificationDismissActionIdentifier {
+                dismissNotification(notification)
             }
         }
+
         completionHandler()
     }
 
@@ -26,7 +40,28 @@ extension NotificationManager: UNUserNotificationCenterDelegate {
         willPresent notification: UNNotification,
         withCompletionHandler completionHandler: @escaping (UNNotificationPresentationOptions) -> Void
     ) {
-        // Don't show system notifications when app is active
-        completionHandler([])
+        completionHandler([.banner, .sound])
+    }
+
+    func setupNotificationDelegate() {
+        UNUserNotificationCenter.current().delegate = self
+
+        // Create action button
+        let action = UNNotificationAction(
+            identifier: "ACTION_BUTTON",
+            title: "Action", // This will be replaced with actual button title
+            options: .foreground
+        )
+
+        // Create category with action button
+        let actionCategory = UNNotificationCategory(
+            identifier: "ACTIONABLE",
+            actions: [action],
+            intentIdentifiers: [],
+            options: .customDismissAction
+        )
+
+        UNUserNotificationCenter.current().setNotificationCategories([actionCategory])
+        UNUserNotificationCenter.current().requestAuthorization(options: [.alert, .sound, .badge]) { _, _ in }
     }
 }

CodeEdit/Features/Notifications/NotificationManager+System.swift

@@ -5,16 +5,19 @@
 //  Created by Austin Condiff on 2/14/24.
 //
 
-import SwiftUI
+import Foundation
 import UserNotifications
 
 extension NotificationManager {
-    /// Shows a notification in macOS Notification Center when app is in background
+    /// Shows a system notification when app is in background
     func showSystemNotification(_ notification: CENotification) {
         let content = UNMutableNotificationContent()
         content.title = notification.title
         content.body = notification.description
-        content.userInfo = ["id": notification.id.uuidString]
+
+        if !notification.actionButtonTitle.isEmpty {
+            content.categoryIdentifier = "ACTIONABLE"
+        }
 
         let request = UNNotificationRequest(
             identifier: notification.id.uuidString,
@@ -25,6 +28,13 @@ extension NotificationManager {
         UNUserNotificationCenter.current().add(request)
     }
 
+    /// Removes a system notification
+    func removeSystemNotification(_ notification: CENotification) {
+        UNUserNotificationCenter.current().removeDeliveredNotifications(
+            withIdentifiers: [notification.id.uuidString]
+        )
+    }
+
     /// Handles response from system notification
     func handleSystemNotificationResponse(id: String) {
         if let uuid = UUID(uuidString: id),