Fixed renaming behavior for pasted file

Author: FastestMolasses

CodeEdit/Features/CEWorkspace/Models/CEWorkspaceFile.swift

@@ -116,7 +116,7 @@ final class CEWorkspaceFile: Codable, Comparable, Hashable, Identifiable, Editor
 
     /// Returns a boolean that is true if the resource represented by this object is a directory.
     lazy var isFolder: Bool = {
-        isPhantom ? resolvedURL.hasDirectoryPath : resolvedURL.isFolder
+        phantomFile != nil ? resolvedURL.hasDirectoryPath : resolvedURL.isFolder
     }()
 
     /// Returns a boolean that is true if the contents of the directory at this path are
@@ -164,8 +164,8 @@ final class CEWorkspaceFile: Codable, Comparable, Hashable, Identifiable, Editor
         FileIcon.iconColor(fileType: type)
     }
 
-    /// Indicates whether the file is phantom (not yet created on disk)
-    var isPhantom: Bool = false
+    /// Holds information about the phantom file
+    var phantomFile: PhantomFile?
 
     init(
         id: String,

CodeEdit/Features/CEWorkspace/Models/PhantomFile.swift

@@ -0,0 +1,12 @@
+//
+//  PhantomFile.swift
+//  CodeEdit
+//
+//  Created by Abe Malla on 7/25/25.
+//
+
+/// Represents a file that doesn't exist on disk
+enum PhantomFile {
+    case empty
+    case pasteboardContent
+}

CodeEdit/Features/NavigatorArea/ProjectNavigator/OutlineView/ProjectNavigatorMenuActions.swift

@@ -107,25 +107,14 @@ extension ProjectNavigatorMenu {
     /// Action that creates a new file with clipboard content
     @objc
     func newFileFromClipboard() {
-        guard let item else { return }
-        do {
-            let clipBoardContent = NSPasteboard.general.string(forType: .string)?.data(using: .utf8)
-            if let clipBoardContent, !clipBoardContent.isEmpty, let newFile = try workspace?
-                .workspaceFileManager?
-                .addFile(
-                    fileName: "untitled",
-                    toFile: item,
-                    contents: clipBoardContent
-                ) {
-                workspace?.listenerModel.highlightedFileItem = newFile
-                workspace?.editorManager?.openTab(item: newFile)
-                self.renameFile()
-            }
-        } catch {
-            let alert = NSAlert(error: error)
-            alert.addButton(withTitle: "Dismiss")
-            alert.runModal()
+        guard item != nil else { return }
+        let clipBoardContent = NSPasteboard.general.string(forType: .string)?.data(using: .utf8)
+
+        guard let clipBoardContent, !clipBoardContent.isEmpty else {
+            return
         }
+
+        createAndAddPhantomFile(isFolder: false, usePasteboardContent: true)
     }
 
     /// Action that creates a new untitled folder
@@ -263,9 +252,9 @@ extension ProjectNavigatorMenu {
         NSPasteboard.general.setString(paths, forType: .string)
     }
 
-    private func createAndAddPhantomFile(isFolder: Bool) {
+    private func createAndAddPhantomFile(isFolder: Bool, usePasteboardContent: Bool = false) {
         guard let item else { return }
-        let phantomFile = CEWorkspaceFile(
+        let file = CEWorkspaceFile(
             id: UUID().uuidString,
             url: item.url
                 .appending(
@@ -275,21 +264,21 @@ extension ProjectNavigatorMenu {
             changeType: nil,
             staged: false
         )
-        phantomFile.isPhantom = true
-        phantomFile.parent = item
+        file.phantomFile = usePasteboardContent ? .pasteboardContent : .empty
+        file.parent = item
 
         // Add phantom file to parent's children temporarily for display
         if let workspace = workspace,
            let fileManager = workspace.workspaceFileManager {
             _ = fileManager.childrenOfFile(item)
-            fileManager.flattenedFileItems[phantomFile.id] = phantomFile
+            fileManager.flattenedFileItems[file.id] = file
             if fileManager.childrenMap[item.id] == nil {
                 fileManager.childrenMap[item.id] = []
             }
-            fileManager.childrenMap[item.id]?.append(phantomFile.id)
+            fileManager.childrenMap[item.id]?.append(file.id)
         }
 
-        workspace?.listenerModel.highlightedFileItem = phantomFile
+        workspace?.listenerModel.highlightedFileItem = file
         sender.outlineView.reloadData()
         self.renameFile()
     }

CodeEdit/Features/NavigatorArea/ProjectNavigator/OutlineView/ProjectNavigatorTableViewCell.swift

@@ -57,7 +57,7 @@ final class ProjectNavigatorTableViewCell: FileSystemTableViewCell {
     override func controlTextDidEndEditing(_ obj: Notification) {
         guard let fileItem else { return }
 
-        if fileItem.isPhantom {
+        if fileItem.phantomFile != nil {
             DispatchQueue.main.async { [weak fileItem, weak self] in
                 guard let fileItem, let self = self else { return }
                 self.handlePhantomFileCompletion(fileItem: fileItem, wasCancelled: false)
@@ -100,7 +100,10 @@ final class ProjectNavigatorTableViewCell: FileSystemTableViewCell {
                     } else {
                         let newFile = try workspaceFileManager.addFile(
                             fileName: newName,
-                            toFile: parent
+                            toFile: parent,
+                            contents: fileItem.phantomFile == PhantomFile.pasteboardContent
+                            ? NSPasteboard.general.string(forType: .string)?.data(using: .utf8)
+                            : nil
                         )
                         workspace.workspace?.listenerModel.highlightedFileItem = newFile
                         workspace.workspace?.editorManager?.openTab(item: newFile)
@@ -140,7 +143,7 @@ final class ProjectNavigatorTableViewCell: FileSystemTableViewCell {
         textView: NSTextView,
         doCommandBy commandSelector: Selector
     ) -> Bool {
-        guard let fileItem, fileItem.isPhantom else { return false }
+        guard let fileItem, fileItem.phantomFile != nil else { return false }
 
         if commandSelector == #selector(NSResponder.cancelOperation(_:)) {
             DispatchQueue.main.async { [weak fileItem, weak self] in

CodeEdit/Features/NavigatorArea/ProjectNavigator/OutlineView/ProjectNavigatorViewController+NSOutlineViewDelegate.swift

@@ -44,7 +44,7 @@ extension ProjectNavigatorViewController: NSOutlineViewDelegate {
 
         guard let item = outlineView.item(atRow: selectedIndex) as? CEWorkspaceFile else { return }
 
-        if !item.isFolder && !item.isPhantom && shouldSendSelectionUpdate {
+        if !item.isFolder && item.phantomFile == nil && shouldSendSelectionUpdate {
             shouldSendSelectionUpdate = false
             if workspace?.editorManager?.activeEditor.selectedTab?.file != item {
                 workspace?.editorManager?.activeEditor.openTab(file: item, asTemporary: true)
@@ -131,7 +131,7 @@ extension ProjectNavigatorViewController: NSOutlineViewDelegate {
         outlineView.selectRowIndexes(.init(integer: row), byExtendingSelection: false)
         shouldSendSelectionUpdate = true
 
-        if fileItem.isPhantom {
+        if fileItem.phantomFile != nil {
             return
         }