Small refactors

Author: FastestMolasses

CodeEdit/Features/LSP/Registry/InstallationQueueManager.swift

@@ -8,7 +8,7 @@
 import Foundation
 
 /// A class to manage queued installations of language servers
-class InstallationQueueManager {
+final class InstallationQueueManager {
     static let shared: InstallationQueueManager = .init()
 
     /// The maximum number of concurrent installations allowed

CodeEdit/Features/LSP/Registry/PackageManagerProtocol.swift

@@ -10,9 +10,14 @@ import Foundation
 protocol PackageManagerProtocol {
     var shellClient: ShellClient { get }
 
+    /// Performs any initialization steps for installing a package, such as creating the directory
+    /// and virtual environments.
     func initialize(in packagePath: URL) async throws
+    /// Calls the shell commands to install a package
     func install(method installationMethod: InstallationMethod) async throws
+    /// Gets the location of the binary that was installed
     func getBinaryPath(for package: String) -> String
+    /// Checks if the shell commands for the package manager are available or not
     func isInstalled() async -> Bool
 }
 

CodeEdit/Features/LSP/Registry/PackageManagers/CargoPackageManager.swift

@@ -7,7 +7,7 @@
 
 import Foundation
 
-class CargoPackageManager: PackageManagerProtocol {
+final class CargoPackageManager: PackageManagerProtocol {
     private let installationDirectory: URL
 
     internal let shellClient: ShellClient
@@ -80,7 +80,7 @@ class CargoPackageManager: PackageManagerProtocol {
             let output = versionOutput.reduce(into: "") {
                 $0 += $1.trimmingCharacters(in: .whitespacesAndNewlines)
             }
-            return output.contains("cargo")
+            return output.starts(with: "cargo")
         } catch {
             print("Cargo version check failed: \(error)")
             return false

CodeEdit/Features/LSP/Registry/PackageManagers/GithubPackageManager.swift

@@ -7,7 +7,7 @@
 
 import Foundation
 
-class GithubPackageManager: PackageManagerProtocol {
+final class GithubPackageManager: PackageManagerProtocol {
     private let installationDirectory: URL
 
     internal let shellClient: ShellClient

CodeEdit/Features/LSP/Registry/PackageManagers/GolangPackageManager.swift

@@ -7,7 +7,7 @@
 
 import Foundation
 
-class GolangPackageManager: PackageManagerProtocol {
+final class GolangPackageManager: PackageManagerProtocol {
     private let installationDirectory: URL
     internal let shellClient: ShellClient
 

CodeEdit/Features/LSP/Registry/PackageManagers/NPMPackageManager.swift

@@ -7,7 +7,7 @@
 
 import Foundation
 
-class NPMPackageManager: PackageManagerProtocol {
+final class NPMPackageManager: PackageManagerProtocol {
     private let installationDirectory: URL
 
     internal let shellClient: ShellClient

CodeEdit/Features/LSP/Registry/PackageManagers/PipPackageManager.swift

@@ -7,7 +7,7 @@
 
 import Foundation
 
-class PipPackageManager: PackageManagerProtocol {
+final class PipPackageManager: PackageManagerProtocol {
     private let installationDirectory: URL
 
     internal let shellClient: ShellClient

CodeEdit/Features/LSP/Registry/RegistryManager.swift

@@ -12,11 +12,7 @@ import ZIPFoundation
 final class RegistryManager {
     static let shared: RegistryManager = .init()
 
-    internal let installPath = FileManager.default.homeDirectoryForCurrentUser
-        .appending(path: "Library")
-        .appending(path: "Application Support")
-        .appending(path: "CodeEdit")
-        .appending(path: "language-servers")
+    internal let installPath = Settings.shared.baseURL.appending(path: "language-servers")
 
     /// The URL of where the registry.json file will be downloaded from
     internal let registryURL = URL(

CodeEdit/Features/Settings/Pages/Extensions/LanguageServerRowView.swift

@@ -245,7 +245,7 @@ struct LanguageServerRowView: View, Equatable {
         let colors: [Color] = [
             .blue, .green, .orange, .red, .purple, .pink, .teal, .yellow, .indigo, .cyan
         ]
-        let hashValue = abs(cleanedTitle.hashValue) % colors.count
+        let hashValue = abs(cleanedTitle.hash) % colors.count
         return AnyShapeStyle(colors[hashValue].gradient)
     }