Logging

[darkl]

There should be logs in the framework.

A logging framework (such as log4net) should be considered.

[darkl]

Being developed on logs branch using Castle ILogger interface. An interesting option is to use LibLog.

Please comment here about specific logs you would like to have from the library.

[shanielh]

Use LibLog 👍

[fconrady]

In the case of Autobahn's Python, JavaScript and C++ clients I found the debug flag helpful. Something similar may be good for WampSharp, for example, being able to see the JSON that was serialized or deserialized.

[darkl]

Yeah, the serialized json is actually written to logs in the develop branch. You are welcome to try it via MyGet feed and add other suggestions.

[BrannonKing]

If you want to expose some Monitor event for logging, that might be handy. Trace calls (System.Diagnostics) would also work, but I generally prefer them less. I would not integrate some 3rd-party logging solution. Leave that to the application-level integration so that they can chose the right logging library for the application -- it's not a framework thing.

[RichiCoder1]

@darkl I actually ran into a perf issue because I was sending not-small json messages over Wamp and the sync logging was waiting to write out massive strings before continueing. I switched the logger to async, but I was wondering if was possible to either A) only write messages on a parse failure or B) but message writing behind it's own flag completely.

[darkl]

Option A is already possible, just set the log level of the logger WampSharp.Newtonsoft.JTokenMessageParser to Error level. Elad

[RichiCoder1]

There's no way to it specifically though, since it pulls the logger effectively out of thin error w/ LibLog. So I'd have to set the context of my whole application to something higher than debug.

[darkl]

I am not around a computer right now, but for example for log4net you need to create a Logger.config with a ROOT logger set to debug and a logger with the name I mentioned set to ERROR. Then you need to call XmlConfigurator.Configure. This should work. Elad

[darkl]

See here for the exact syntax. https://logging.apache.org/log4net/release/manual/configuration.html

[RichiCoder1]

I utilize Serilog, but the issue is I'd like to keep the log level set to Debug and have Json messages not automatically be written, even at Debug level.

[darkl]

So manually change the log level of this specific logger. This is one of the things logging frameworks are for.