Skip to content

Commit 2d483e2

Browse files
authored
Merge pull request #2046 from susegrant/patch-5
azure-events: backport relevant changes from azure-events-az
2 parents 99f301e + 4480315 commit 2d483e2

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

heartbeat/azure-events.in

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -602,21 +602,21 @@ class Node:
602602
ocf.logger.info("handleRemoteEvents: handling remote event %s (%s; nodes = %s)" % (e.EventId, e.EventType, str(e.Resources)))
603603
# before we can force an event to start, we need to ensure all nodes involved have stopped their resources
604604
if e.EventStatus == "Scheduled":
605-
allNodesStopped = True
605+
allResourcesNowStopped = True
606606
for azName in e.Resources:
607607
hostName = clusterHelper.getHostNameFromAzName(azName)
608608
state = self.getState(node=hostName)
609609
if state == STOPPING:
610610
# the only way we can continue is when node state is STOPPING, but all resources have been stopped
611611
if not clusterHelper.allResourcesStoppedOnNode(hostName):
612-
ocf.logger.info("handleRemoteEvents: (at least) node %s has still resources running -> wait" % hostName)
613-
allNodesStopped = False
612+
ocf.logger.info("handleRemoteEvents: (at least) node %s still has resources running -> wait" % hostName)
613+
allResourcesNowStopped = False
614614
break
615615
elif state in (AVAILABLE, IN_EVENT, ON_HOLD):
616616
ocf.logger.info("handleRemoteEvents: node %s is still %s -> remote event needs to be picked up locally" % (hostName, nodeStateToString(state)))
617-
allNodesStopped = False
617+
allResourcesNowStopped = False
618618
break
619-
if allNodesStopped:
619+
if allResourcesNowStopped:
620620
ocf.logger.info("handleRemoteEvents: nodes %s are stopped -> add remote event %s to force list" % (str(e.Resources), e.EventId))
621621
for n in e.Resources:
622622
hostName = clusterHelper.getHostNameFromAzName(n)
@@ -698,11 +698,11 @@ class Node:
698698
ocf.logger.debug("handleLocalEvents: no local azEvents to handle")
699699
if curState == STOPPING:
700700
if clusterHelper.noPendingResourcesOnNode(self.hostName):
701-
ocf.logger.info("handleLocalEvents: all local resources are started properly -> put node standby")
701+
ocf.logger.info("handleLocalEvents: all local resources are stopped -> put node standby")
702702
self.putNodeStandby()
703703
mayUpdateDocVersion = True
704704
else:
705-
ocf.logger.info("handleLocalEvents: some local resources are not clean yet -> wait")
705+
ocf.logger.info("handleLocalEvents: some local resources are not stopped yet -> wait")
706706

707707
ocf.logger.debug("handleLocalEvents: finished; mayUpdateDocVersion = %s" % str(mayUpdateDocVersion))
708708
return mayUpdateDocVersion
@@ -801,6 +801,7 @@ away from the affected node to allow for a graceful shutdown.
801801

802802
Deployment:
803803
crm configure primitive rsc_azure-events ocf:heartbeat:azure-events \
804+
params eventTypes=Reboot,Redeploy verbose=false \
804805
op monitor interval=10s
805806
crm configure clone cln_azure-events rsc_azure-events
806807

0 commit comments

Comments
 (0)