ipc: use O_EXCL when opening IPC files

chrissie-c · chrissie-c · commit 269a0ca00717 · 2019-04-08T13:31:38.000+01:00
diff --git a/lib/ipc_socket.c b/lib/ipc_socket.c
@@ -790,7 +790,7 @@ qb_ipcs_us_connect(struct qb_ipcs_service *s,
 
 	fd_hdr = qb_sys_mmap_file_open(path, r->request,
 				       SHM_CONTROL_SIZE,
-				       O_CREAT | O_TRUNC | O_RDWR);
+				       O_CREAT | O_TRUNC | O_RDWR | O_EXCL);
 	if (fd_hdr < 0) {
 		res = fd_hdr;
 		errno = -fd_hdr;
diff --git a/lib/ringbuffer.c b/lib/ringbuffer.c
@@ -155,7 +155,7 @@ qb_rb_open_2(const char *name, size_t size, uint32_t flags,
 	    sizeof(struct qb_ringbuffer_shared_s) + shared_user_data_size;
 
 	if (flags & QB_RB_FLAG_CREATE) {
-		file_flags |= O_CREAT | O_TRUNC;
+		file_flags |= O_CREAT | O_TRUNC | O_EXCL;
 	}
 
 	rb = calloc(1, sizeof(struct qb_ringbuffer_s));

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ qb_rb_open_2(const char *name, size_t size, uint32_t flags,`
`155`	`155`	`sizeof(struct qb_ringbuffer_shared_s) + shared_user_data_size;`
`156`	`156`
`157`	`157`	`if (flags & QB_RB_FLAG_CREATE) {`
`158`		`- file_flags \|= O_CREAT \| O_TRUNC;`
	`158`	`+ file_flags \|= O_CREAT \| O_TRUNC \| O_EXCL;`
`159`	`159`	`}`
`160`	`160`
`161`	`161`	`rb = calloc(1, sizeof(struct qb_ringbuffer_s));`