Support input of container sizes

[nilsga]

If you extend this script to also support an array of possible container sizes, and then finding the combination that fits all boxes, it would be even more perfect :)

Example:

$container_sizes = array(
    array(
        'length' => 10,
        'height' => 5,
        'width' => 25
    ),
    array(
        'length' => 15,
        'height' => 15,
        'width' => 40
    )
);

$boxes = array(); // Boxes with dimensions

$packer = new LAFFPacker();
$packer->pack($boxes, $container_sizes);

$containers = $packer->get_containers(); // Array of containers

[mdeboer]

That's a great idea! I'll have a go at it after I'm back from holiday and have a bit more time to spend.

[2ndMile]

Hi mdeboer,

Thanks for the great piece of code. I am implementing it in a Drupal Commerce shipping module. I see that you added the ability to specify container size. I see the note about not specifying the height of the container. I find this interesting. If I want to specify a size of a container, the height would be part of that... and then I would just have left over product that doesn't fit. I am just wondering about your decision to calculate the container height on the fly.

[mdeboer]

Hi 2ndMile!

With all the millions of things going on in my life I forgot about it unfortunately, yet I'm willing to still make the change if you like and it's great to hear that you're implementing it in a Drupal Commerce module!

Not sure about the comment about the height, I think this had to do with two "modes", either finding out how many boxes you need (total calculated height / box height) and a mode that just checks whether it fits or not. But I'll look into that and update the documentation on that a bit!

If you got any questions, feel free to send me an email (info@maartendeboer.net) or file a bug report/feature request!

[mdeboer]

I looked into the issue and I think it's best to first make the code a bit more OOP, this makes it a lot easier to work with multiple containers. This also allows you to add more data to boxes and containers and extend the whole code a lot easier.

Anyway, I'll start working on this in my spare time so bear with me! I'll keep you guys posted 👍

[2ndMile]

Good to hear. I worked on the implementation some last night. Since the height was returned (using my width and length) I compared it with the height of the physical container being packed. This works out well.

You saved me a lot of hair pulling. I am using some code from https://drupal.org/sandbox/jhaskins/1873204 to make my module. Most of the shipping modules available for Drupal Commerce are pretty bad when it comes to packing products in containers. Many of them have their own packing algorithm built-in and none of them are good. Joe's idea (the author of the Commerce module) of separating the packing logic from the rate retrieval makes sense on many levels. I am trying to contact him to see if he wants to implement your class. If not, I will go out on my own and try to get this into some useable form for the community.

[mdeboer]

Awesome that's great! I'll make another branch with unstable course for testing soon :)

Update: I decided not to get in to branching but I tagged this initial release as v1.0 and created a milestone for this task for v2.0 which will be just here in the master branch.

[mdeboer]

Happy Christmas by the way!

[2ndMile]

Merry Christmas to you too!

[mdeboer]

I worked on the code making it more OOP and easy to develop, first few commits should come soon. Got some other projects that require my attention as well :)

[obfuscode]

hey mdeboer - any chance you implemented this? I don't care if it's rough code - would really love it if you have it laying around!

[nguyenanhthai]

Hi guys,
Your work is awesome!
I have written some extend lines for your class that can limit the height of container box. When we limit the height of container, we can run the packing algorithm recursively on remaining boxes. So there we can resolve the problem with several containers.

However, when we have several containers, we have a confusion (fuzzy) when choose which containers has the highest priority to pack first.
So there if we have several containers, we will have several solutions for one packing problem. Then, we need some further way to handle (sorting, filtering) for generated solutions.