Skip to content

Conversation

@nomis52
Copy link

@nomis52 nomis52 commented Aug 25, 2025

Breaking change

Hopefully not!

Proposed change

This PR adds "type": "module" to the package.json to enable ES module support in the project and fixes all compatibility issues that resulted from this change. This is a prerequisite for introducing Jest testing framework to the repository.

This configures Node.js to treat .js files as ES modules by default

  • Added "type": "module" field to package.json
  • Fixed missing .js extension in import statement (tap-actions.js)
  • Converted JSON translation files to JavaScript modules with proper default exports
  • Updated localize.js to import from .js files instead of .json files
  • Renamed webpack.config.js to webpack.config.cjs (CommonJS module for Node.js compatibility)

Tested on my own instance of Home Assistant which is how I noticed the translation failures.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

N/A

Example printscreens/gif

N/A

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Additional documentation needed.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests screenshots/gifs have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for readme.

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Oct 25, 2025
@nomis52
Copy link
Author

nomis52 commented Oct 25, 2025

@Clooos any interest in these and #1785 ?

@github-actions github-actions bot removed the stale label Oct 25, 2025
@Clooos
Copy link
Owner

Clooos commented Oct 27, 2025

@Clooos any interest in these and #1785 ?

Hi! Yes of course! And thank you so much for these!

I'm so busy these days, working on Bubble Card is taking so much of my free time that I forget to answer to everyone 😅

But I will definitely take a look at your work before my next release, so don't worry for that! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants