Run SwiftLint on danger-swiftlint (#37)

Econa77 · web-flow · commit 9d99cfde65bb · 2020-04-30T22:28:45.000+09:00
* Run SwiftLint on danger-swiftlint

* swiftlint
diff --git a/.github/workflows/Danger.yml b/.github/workflows/Danger.yml
@@ -0,0 +1,56 @@
+name: Danger
+
+on: pull_request
+
+jobs:
+  danger:
+
+    runs-on: macos-latest
+
+    steps:
+    - uses: actions/checkout@v1
+      with:
+        submodules: true
+
+    - name: Setup ruby
+      uses: actions/setup-ruby@v1
+      with:
+        ruby-version: '2.6'
+
+    - name: Select Xcode
+      run: sudo xcode-select -s /Applications/Xcode_11.4.app
+
+    - name: Cache RubyGems
+      uses: actions/cache@v1
+      with:
+        path: vendor/bundle
+        key: ${{ runner.os }}-gem-${{ hashFiles('**/Gemfile.lock') }}
+        restore-keys: |
+          ${{ runner.os }}-gem-
+
+    - name: Cache Mint packages
+      uses: actions/cache@v1
+      with:
+        path: ${{ env.MINT_PATH }}
+        key: ${{ runner.os }}-mint-${{ hashFiles('**/Mintfile') }}
+        restore-keys: |
+          ${{ runner.os }}-mint-
+
+    - name: Bundle install
+      run: |
+        gem install bundler
+        bundle config path vendor/bundle
+        bundle install --jobs 4 --retry 3
+
+    - name: Install Mint and Packages
+      run: |
+        brew install mint
+        mint bootstrap --link
+
+    - name: Run Danger
+      run: bundle exec danger
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+    env:
+      MINT_PATH: mint
diff --git a/.swiftlint.yml b/.swiftlint.yml
@@ -0,0 +1,38 @@
+included:
+  - Lib/KeyHolder
+  - Lib/KeyHolderTests
+opt_in_rules:
+  - empty_count
+  - explicit_init
+  - closure_spacing
+  - overridden_super_call
+  - redundant_nil_coalescing
+  - private_outlet
+  - nimble_operator
+  - operator_usage_whitespace
+  - closure_end_indentation
+  - first_where
+  - prohibited_super_call
+  - vertical_parameter_alignment_on_call
+  - unneeded_parentheses_in_closure_argument
+  - extension_access_modifier
+  - literal_expression_end_indentation
+  - joined_default_parameter
+  - contains_over_first_not_nil
+  - override_in_extension
+  - private_action
+  - quick_discouraged_call
+  - quick_discouraged_focused_test
+  - quick_discouraged_pending_test
+  - single_test_class
+  - sorted_first_last
+  - yoda_condition
+disabled_rules:
+  - nesting
+  - function_parameter_count
+identifier_name:
+  excluded:
+    - i
+    - x
+    - y
+line_length: 300
diff --git a/Dangerfile b/Dangerfile
@@ -0,0 +1,3 @@
+github.dismiss_out_of_range_messages
+swiftlint.config_file = '.swiftlint.yml'
+swiftlint.lint_files(inline_mode: true)
diff --git a/Gemfile b/Gemfile
@@ -1,3 +1,5 @@
 source 'https://rubygems.org'
 
 gem 'cocoapods'
+gem "danger"
+gem "danger-swiftlint"
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -7,11 +7,17 @@ GEM
       minitest (~> 5.1)
       thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
     algoliasearch (1.27.2)
       httpclient (~> 2.8, >= 2.8.3)
       json (>= 1.5.1)
     atomos (0.1.3)
     claide (1.0.3)
+    claide-plugins (0.9.2)
+      cork
+      nap
+      open4 (~> 1.3)
     cocoapods (1.9.1)
       activesupport (>= 4.0.2, < 5)
       claide (>= 1.0.2, < 2.0)
@@ -51,28 +57,74 @@ GEM
     cocoapods-try (1.2.0)
     colored2 (3.1.2)
     concurrent-ruby (1.1.6)
+    cork (0.3.0)
+      colored2 (~> 3.1)
+    danger (7.0.0)
+      claide (~> 1.0)
+      claide-plugins (>= 0.9.2)
+      colored2 (~> 3.1)
+      cork (~> 0.1)
+      faraday (>= 0.9.0, < 2.0)
+      faraday-http-cache (~> 2.0)
+      git (~> 1.6)
+      kramdown (~> 2.0)
+      kramdown-parser-gfm (~> 1.0)
+      no_proxy_fix
+      octokit (~> 4.7)
+      terminal-table (~> 1)
+    danger-swiftlint (0.24.2)
+      danger
+      rake (> 10)
+      thor (~> 0.19)
     escape (0.0.4)
     ethon (0.12.0)
       ffi (>= 1.3.0)
+    faraday (1.0.1)
+      multipart-post (>= 1.2, < 3)
+    faraday-http-cache (2.2.0)
+      faraday (>= 0.8)
     ffi (1.12.2)
     fourflusher (2.3.1)
     fuzzy_match (2.0.4)
     gh_inspector (1.1.3)
+    git (1.7.0)
+      rchardet (~> 1.8)
     httpclient (2.8.3)
     i18n (0.9.5)
       concurrent-ruby (~> 1.0)
     json (2.3.0)
+    kramdown (2.2.1)
+      rexml
+    kramdown-parser-gfm (1.1.0)
+      kramdown (~> 2.0)
     minitest (5.14.0)
     molinillo (0.6.6)
+    multipart-post (2.1.1)
     nanaimo (0.2.6)
     nap (1.1.0)
     netrc (0.11.0)
+    no_proxy_fix (0.1.2)
+    octokit (4.18.0)
+      faraday (>= 0.9)
+      sawyer (~> 0.8.0, >= 0.5.3)
+    open4 (1.3.4)
+    public_suffix (4.0.4)
+    rake (13.0.1)
+    rchardet (1.8.0)
+    rexml (3.2.4)
     ruby-macho (1.4.0)
+    sawyer (0.8.2)
+      addressable (>= 2.3.5)
+      faraday (> 0.8, < 2.0)
+    terminal-table (1.8.0)
+      unicode-display_width (~> 1.1, >= 1.1.1)
+    thor (0.20.3)
     thread_safe (0.3.6)
     typhoeus (1.3.1)
       ethon (>= 0.9.0)
     tzinfo (1.2.7)
       thread_safe (~> 0.1)
+    unicode-display_width (1.7.0)
     xcodeproj (1.16.0)
       CFPropertyList (>= 2.3.3, < 4.0)
       atomos (~> 0.1.3)
@@ -85,6 +137,8 @@ PLATFORMS
 
 DEPENDENCIES
   cocoapods
+  danger
+  danger-swiftlint
 
 BUNDLED WITH
    2.0.2
diff --git a/Lib/KeyHolder/RecordView.swift b/Lib/KeyHolder/RecordView.swift
@@ -22,7 +22,8 @@ public protocol RecordViewDelegate: class {
     func recordViewDidEndRecording(_ recordView: RecordView)
 }
 
-@IBDesignable open class RecordView: NSView {
+@IBDesignable
+open class RecordView: NSView {
 
     // MARK: - Properties
     @IBInspectable open var backgroundColor: NSColor = .white {
@@ -306,14 +307,14 @@ public protocol RecordViewDelegate: class {
 
             // Clean Flag
             let delay = 0.3 * Double(NSEC_PER_SEC)
-            let time  = DispatchTime.now() + Double(Int64(delay)) / Double(NSEC_PER_SEC)
+            let time = DispatchTime.now() + Double(Int64(delay)) / Double(NSEC_PER_SEC)
             DispatchQueue.main.asyncAfter(deadline: time, execute: { [weak self] in
                 self?.doubleTapModifier = NSEvent.ModifierFlags(rawValue: 0)
             })
         } else {
             inputModifiers = NSEvent.ModifierFlags(rawValue: 0)
         }
-        
+
         super.flagsChanged(with: theEvent)
     }
 
@@ -350,14 +351,14 @@ extension RecordView {
 }
 
 // MARK: - Recording
-extension RecordView {
-    public func beginRecording() -> Bool {
+public extension RecordView {
+    func beginRecording() -> Bool {
         if !isEnabled { return false }
         if isRecording { return true }
 
         needsDisplay = true
 
-        if let delegate = delegate , !delegate.recordViewShouldBeginRecording(self) {
+        if let delegate = delegate, !delegate.recordViewShouldBeginRecording(self) {
             NSSound.beep()
             return false
         }
@@ -371,7 +372,7 @@ extension RecordView {
         return true
     }
 
-    public func endRecording() {
+    func endRecording() {
         if !isRecording { return }
 
         inputModifiers = NSEvent.ModifierFlags(rawValue: 0)
@@ -391,40 +392,40 @@ extension RecordView {
 }
 
 // MARK: - Clear Keys
-extension RecordView {
-    public func clear() {
+public extension RecordView {
+    func clear() {
         keyCombo = nil
         inputModifiers = NSEvent.ModifierFlags(rawValue: 0)
         needsDisplay = true
         didChange?(nil)
         delegate?.recordViewDidClearShortcut(self)
     }
 
-    @objc public func clearAndEndRecording() {
+    @objc func clearAndEndRecording() {
         clear()
         endRecording()
     }
 }
 
 // MARK: - Modifiers
-extension RecordView {
-    fileprivate func validateModifiers(_ modifiers: NSEvent.ModifierFlags?) -> Bool {
+private extension RecordView {
+    func validateModifiers(_ modifiers: NSEvent.ModifierFlags?) -> Bool {
         guard let modifiers = modifiers else { return false }
         return KeyTransformer.carbonFlags(from: modifiers) != 0
     }
 }
 
 // MARK: - Bool Extension
-extension Bool {
-    fileprivate var intValue: Int {
+private extension Bool {
+    var intValue: Int {
         return NSNumber(value: self).intValue
     }
 }
 
 // MARK: - NSColor Extensio
 // nmacOS 10.14 polyfill
-extension NSColor {
-    fileprivate static let controlAccentPolyfill: NSColor = {
+private extension NSColor {
+    static let controlAccentPolyfill: NSColor = {
         if #available(macOS 10.14, *) {
             return NSColor.controlAccentColor
         } else {
diff --git a/Lib/KeyHolderTests/KeyHolderTests.swift b/Lib/KeyHolderTests/KeyHolderTests.swift
@@ -14,27 +14,20 @@ import XCTest
 @testable import KeyHolder
 
 class KeyHolderTests: XCTestCase {
-    
+
     override func setUp() {
         super.setUp()
-        // Put setup code here. This method is called before the invocation of each test method in the class.
     }
-    
+
     override func tearDown() {
-        // Put teardown code here. This method is called after the invocation of each test method in the class.
         super.tearDown()
     }
-    
-    func testExample() {
-        // This is an example of a functional test case.
-        // Use XCTAssert and related functions to verify your tests produce the correct results.
-    }
-    
+
+    func testExample() {}
+
     func testPerformanceExample() {
-        // This is an example of a performance test case.
         self.measure {
-            // Put the code you want to measure the time of here.
         }
     }
-    
+
 }
diff --git a/Mintfile b/Mintfile
@@ -0,0 +1 @@
+realm/SwiftLint@0.39.1

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+github.dismiss_out_of_range_messages`
	`2`	`+swiftlint.config_file = '.swiftlint.yml'`
	`3`	`+swiftlint.lint_files(inline_mode: true)`