Skip to content

Commit f7b82a4

Browse files
authored
Merge pull request nf-core#732 from nf-core/mscsq_mspli_update
Switch local most severe consequence & pli scripts for the nf-core ones
2 parents 5ef99db + b587680 commit f7b82a4

File tree

18 files changed

+388
-173
lines changed

18 files changed

+388
-173
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1212
### `Changed`
1313

1414
- Use distinct output filenames for bcfools (in call_mobile_elements subworkflow) and svdb (in call_sv_tiddit subworkflow) [#716](https://github.com/nf-core/raredisease/pull/716)
15+
- Use nf-core's most severe consequence & pli scripts instead of local ones [#732](https://github.com/nf-core/raredisease/pull/732)
1516

1617
### `Fixed`
1718

conf/modules/annotate_consequence_pli.config

Lines changed: 14 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -14,61 +14,55 @@
1414

1515
process {
1616

17-
withName: '.*ANN_CSQ_PLI_SV:ADD_MOST_SEVERE_CSQ' {
17+
withName: '.*ANN_CSQ_PLI_SV:CUSTOM_ADDMOSTSEVERECONSEQUENCE' {
1818
ext.prefix = { "${meta.id}_sv_csq_${meta.set}" }
1919
}
2020

21-
withName: '.*ANN_CSQ_PLI_SV:ADD_MOST_SEVERE_PLI' {
21+
withName: '.*ANN_CSQ_PLI_SV:CUSTOM_ADDMOSTSEVEREPLI' {
2222
ext.prefix = { "${meta.id}_sv_csq_pli_${meta.set}" }
2323
}
2424

25-
withName: '.*ANN_CSQ_PLI_SV:TABIX_BGZIPTABIX' {
26-
ext.prefix = { "${meta.id}_sv_csq_pli_${meta.set}" }
27-
}
2825
}
2926

3027
process {
3128

32-
withName: '.*ANN_CSQ_PLI_SNV:ADD_MOST_SEVERE_CSQ' {
29+
withName: '.*ANN_CSQ_PLI_SNV:CUSTOM_ADDMOSTSEVERECONSEQUENCE' {
3330
ext.prefix = { "${meta.id}_snv_csq_${meta.set}" }
3431
}
3532

36-
withName: '.*ANN_CSQ_PLI_SNV:ADD_MOST_SEVERE_PLI' {
33+
withName: '.*ANN_CSQ_PLI_SNV:CUSTOM_ADDMOSTSEVEREPLI' {
3734
ext.prefix = { "${meta.id}_snv_csq_pli_${meta.set}" }
3835
}
3936

40-
withName: '.*ANN_CSQ_PLI_SNV:TABIX_BGZIPTABIX' {
41-
ext.prefix = { "${meta.id}_snv_csq_pli_${meta.set}" }
42-
}
4337
}
4438

4539
process {
4640

47-
withName: '.*ANN_CSQ_PLI_MT:ADD_MOST_SEVERE_CSQ' {
41+
withName: '.*ANN_CSQ_PLI_MT:CUSTOM_ADDMOSTSEVERECONSEQUENCE' {
4842
ext.prefix = { "${meta.id}_mt_csq_${meta.set}" }
4943
}
5044

51-
withName: '.*ANN_CSQ_PLI_MT:ADD_MOST_SEVERE_PLI' {
45+
withName: '.*ANN_CSQ_PLI_MT:CUSTOM_ADDMOSTSEVEREPLI' {
5246
ext.prefix = { "${meta.id}_mt_csq_pli_${meta.set}" }
5347
}
5448

55-
withName: '.*ANN_CSQ_PLI_MT:TABIX_BGZIPTABIX' {
56-
ext.prefix = { "${meta.id}_mt_csq_pli_${meta.set}" }
57-
}
5849
}
5950

6051
process {
6152

62-
withName: '.*ANN_CSQ_PLI_ME:ADD_MOST_SEVERE_CSQ' {
53+
withName: '.*ANN_CSQ_PLI_ME:CUSTOM_ADDMOSTSEVERECONSEQUENCE' {
6354
ext.prefix = { "${meta.id}_me_csq_${meta.set}" }
6455
}
6556

66-
withName: '.*ANN_CSQ_PLI_ME:ADD_MOST_SEVERE_PLI' {
57+
withName: '.*ANN_CSQ_PLI_ME:CUSTOM_ADDMOSTSEVEREPLI' {
6758
ext.prefix = { "${meta.id}_me_pli_${meta.set}" }
59+
publishDir = [
60+
path: { "${params.outdir}/annotate_mobile_elements" },
61+
mode: params.publish_dir_mode,
62+
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
63+
]
6864
}
69-
70-
withName: '.*ANN_CSQ_PLI_ME:TABIX_BGZIPTABIX' {
71-
ext.prefix = { "${meta.id}_me_annotated_${meta.set}" }
65+
withName: '.*ANN_CSQ_PLI_ME:TABIX_TABIX' {
7266
publishDir = [
7367
path: { "${params.outdir}/annotate_mobile_elements" },
7468
mode: params.publish_dir_mode,

conf/test.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ params {
3737
pipelines_testdata_base_path = 'https://raw.githubusercontent.com/nf-core/test-datasets/raredisease'
3838

3939
skip_tools = 'fastp,gens,haplogrep3,peddy,germlinecnvcaller,qualimap,eklipse,ngsbits'
40-
skip_subworkflows = "mt_annotation,mt_subsample,me_calling,me_annotation,sv_annotation"
40+
skip_subworkflows = "mt_annotation,mt_subsample,sv_annotation"
4141

4242
input = params.pipelines_testdata_base_path + '/testdata/samplesheet_fq_spring.csv'
4343
fasta = params.pipelines_testdata_base_path + '/reference/reference.fasta'

modules.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,16 @@
116116
"git_sha": "666652151335353eef2fcd58880bcef5bc2928e1",
117117
"installed_by": ["modules"]
118118
},
119+
"custom/addmostsevereconsequence": {
120+
"branch": "master",
121+
"git_sha": "56f5268d044a61636f55c3935e2d5b23b65437e1",
122+
"installed_by": ["modules"]
123+
},
124+
"custom/addmostseverepli": {
125+
"branch": "master",
126+
"git_sha": "56f5268d044a61636f55c3935e2d5b23b65437e1",
127+
"installed_by": ["modules"]
128+
},
119129
"deepvariant/rundeepvariant": {
120130
"branch": "master",
121131
"git_sha": "470ac76fb4fbba2a9284c8b65191119c8bfe5a69",

modules/local/add_most_severe_consequence/main.nf

Lines changed: 0 additions & 44 deletions
This file was deleted.

modules/local/add_most_severe_pli/main.nf

Lines changed: 0 additions & 43 deletions
This file was deleted.

modules/nf-core/custom/addmostsevereconsequence/main.nf

Lines changed: 61 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/nf-core/custom/addmostsevereconsequence/meta.yml

Lines changed: 66 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bin/add_most_severe_consequence.py renamed to modules/nf-core/custom/addmostsevereconsequence/resources/usr/bin/add_most_severe_consequence.py

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/nf-core/custom/addmostseverepli/main.nf

Lines changed: 58 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)