Skip to content

Commit 1572d16

Browse files
Garvit SharmaGarvit Sharma
authored andcommitted
Fix PR review feedback
1 parent c68cbbe commit 1572d16

3 files changed

Lines changed: 18 additions & 8 deletions

File tree

frontend/src/components/ui/ApiError.tsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,12 @@ export function ApiError({ message, onDismiss }: ApiErrorProps) {
1717
<p className="text-sm break-words">{message}</p>
1818
</div>
1919

20-
<button
21-
onClick={onDismiss}
22-
aria-label="Dismiss error"
23-
className="cursor-pointer hover:text-red-400 transition-colors"
24-
>
20+
<button
21+
type="button"
22+
onClick={onDismiss}
23+
aria-label="Dismiss"
24+
className="cursor-pointer hover:text-red-400 transition-colors"
25+
>
2526
<X className="w-4 h-4" />
2627
</button>
2728
</div>

frontend/src/pages/NewAnalysis.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,13 @@ export default function NewAnalysis() {
9191
onClick: () => navigate('/runs'),
9292
})
9393
} catch (e:any) {
94-
const message = e?.response?.data?.detail || e?.message || "Something went wrong";
95-
setError(message);
94+
const message =
95+
e?.response?.data?.detail ||
96+
e?.response?.data?.message ||
97+
e?.message ||
98+
'Prediction failed'
99+
setError(message)
100+
showToast('error', message)
96101
} finally {
97102
setBusy(false)
98103
}

frontend/src/pages/Upload.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,11 @@ export default function Upload() {
7979
setFile(null)
8080
setUploadProgress(null)
8181
} catch (e:any) {
82-
const message = e?.response?.data?.detail || e?.message || "Upload failed";
82+
const message =
83+
e?.response?.data?.detail ||
84+
e?.response?.data?.message ||
85+
e?.message ||
86+
'Upload failed'
8387
setError(message);
8488
setUploadProgress(null);
8589
} finally {

0 commit comments

Comments
 (0)