fix: improve docker container support for config and database

- Auto-detect container environment and search /config for config files
- Create parent directories before initializing SQLite database
- Make initDatabase async to support directory creation
- Update README with Docker volume mount documentation

Author: adiologydev

README.md

@@ -409,19 +409,58 @@ docker run --rm -v postgres_data_restored:/data -v /tmp/restore:/backup alpine \
 
 ### Docker
 
+The Docker image uses three volume mount points:
+
+| Mount Point | Purpose |
+|-------------|---------|
+| `/config` | Config file (`backitup.config.yaml`) and database |
+| `/data` | Source files to backup (or mount your own paths) |
+| `/backups` | Local backup storage destination |
+
 ```bash
 docker run -d --name backitup \
-  -v ./config:/config:ro -v ./data:/data -v ./backups:/backups \
-  -e S3_ACCESS_KEY_ID=key -e S3_SECRET_ACCESS_KEY=secret \
+  -v ./config:/config \
+  -v ./data:/data:ro \
+  -v ./backups:/backups \
+  -e S3_ACCESS_KEY_ID=key \
+  -e S3_SECRET_ACCESS_KEY=secret \
   ghcr.io/climactic/backitup:latest start
 ```
 
+Your config file should reference these paths:
+
+```yaml
+# /config/backitup.config.yaml
+version: "1.0"
+database:
+  path: /config/backitup.db
+sources:
+  app:
+    path: /data
+local:
+  enabled: true
+  path: /backups
+```
+
 To backup Docker volumes from within a container, mount the Docker socket:
 
 ```bash
 docker run -d --name backitup \
   -v /var/run/docker.sock:/var/run/docker.sock \
-  -v ./config:/config:ro -v ./data:/data -v ./backups:/backups \
+  -v ./config:/config \
+  -v ./data:/data:ro \
+  -v ./backups:/backups \
+  ghcr.io/climactic/backitup:latest start
+```
+
+You can also mount specific host paths instead of using `/data`:
+
+```bash
+docker run -d --name backitup \
+  -v ./config:/config \
+  -v /var/www/myapp:/myapp:ro \
+  -v /var/lib/postgres:/postgres:ro \
+  -v ./backups:/backups \
   ghcr.io/climactic/backitup:latest start
 ```
 
@@ -433,9 +472,9 @@ services:
     image: ghcr.io/climactic/backitup:latest
     command: start
     volumes:
-      - ./config:/config:ro
-      - ./data:/data
-      - ./backups:/backups
+      - ./config:/config              # Config + database
+      - ./data:/data:ro               # Source files (read-only)
+      - ./backups:/backups            # Local backup destination
       - /var/run/docker.sock:/var/run/docker.sock  # For volume backups
     environment:
       - S3_ACCESS_KEY_ID=key

src/cli/commands/list.ts

@@ -38,7 +38,7 @@ export async function listCommand(args: string[]): Promise<number> {
 
   try {
     const config = await findAndLoadConfig(values.config);
-    initDatabase(config.database.path);
+    await initDatabase(config.database.path);
 
     // Get backups
     let backups: BackupRecord[];

src/cli/commands/verify.ts

@@ -41,7 +41,7 @@ export async function verifyCommand(args: string[]): Promise<number> {
 
   try {
     const config = await findAndLoadConfig(values.config);
-    initDatabase(config.database.path);
+    await initDatabase(config.database.path);
 
     ui.intro("backitup verify");
 

src/config/loader.ts

@@ -73,15 +73,54 @@ function parseConfigContent(content: string, ext: string): unknown {
 }
 
 /**
- * Find a config file in the given directory
+ * Check if running inside a Docker container
+ */
+function isRunningInDocker(): boolean {
+  try {
+    // Check for .dockerenv file (most reliable)
+    if (Bun.file("/.dockerenv").size >= 0) {
+      return true;
+    }
+  } catch {
+    // File doesn't exist
+  }
+
+  try {
+    // Check cgroup for docker/container references
+    const cgroup = Bun.file("/proc/1/cgroup");
+    if (cgroup.size > 0) {
+      // We can't easily read sync here, so just check if the file exists
+      // The /.dockerenv check above is the primary method
+    }
+  } catch {
+    // Not on Linux or file not accessible
+  }
+
+  return false;
+}
+
+/**
+ * Find a config file in the given directory or standard locations
  */
 export function findConfigFile(startDir: string = process.cwd()): string | null {
   const configNames = ["backitup.config.yaml", "backitup.config.yml", "backitup.config.json"];
+  const searchDirs = [startDir];
+
+  // Only check /config when running in Docker
+  if (isRunningInDocker()) {
+    searchDirs.push("/config");
+  }
 
-  for (const name of configNames) {
-    const configPath = path.join(startDir, name);
-    if (Bun.file(configPath).size > 0) {
-      return configPath;
+  for (const dir of searchDirs) {
+    for (const name of configNames) {
+      const configPath = path.join(dir, name);
+      try {
+        if (Bun.file(configPath).size > 0) {
+          return configPath;
+        }
+      } catch {
+        // Directory doesn't exist or not accessible, continue
+      }
     }
   }
 

src/core/backup/orchestrator.ts

@@ -62,7 +62,7 @@ export async function runBackup(
 
   logger.info(`Starting backup: ${backupId} (schedule: ${options.schedule})`);
 
-  initDatabase(config.database.path);
+  await initDatabase(config.database.path);
 
   const useS3 = config.s3.enabled && !options.localOnly;
   const useLocal = config.local.enabled && !options.s3Only;

src/core/cleanup/orchestrator.ts

@@ -35,7 +35,7 @@ export async function runCleanup(
   config: BackitupConfig,
   options: CleanupOptions,
 ): Promise<CleanupResult> {
-  initDatabase(config.database.path);
+  await initDatabase(config.database.path);
 
   if (config.s3.enabled) {
     initS3Client(config.s3);

src/db/connection.ts

@@ -2,16 +2,21 @@
  * Database connection management
  */
 
+import { mkdir } from "node:fs/promises";
+import { dirname } from "node:path";
 import { Database } from "bun:sqlite";
 import { initializeDatabase } from "./migrations";
 
 let db: Database | null = null;
 
-export function initDatabase(dbPath: string): Database {
+export async function initDatabase(dbPath: string): Promise<Database> {
   if (db) {
     return db;
   }
 
+  // Ensure parent directory exists
+  await mkdir(dirname(dbPath), { recursive: true });
+
   db = new Database(dbPath, { create: true });
   initializeDatabase(db);