Skip to content

Commit e63c4f1

Browse files
authored
Merge pull request #2 from Clever/limiter-error-logging
Only log when limiter errors are not nil.
2 parents 393b953 + 60b1b3b commit e63c4f1

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

client.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -626,11 +626,13 @@ func (c *Client) Do(req *Request) (*http.Response, error) {
626626
}
627627

628628
limiterErr := c.Limiter(req.Context())
629-
switch v := logger.(type) {
630-
case LeveledLogger:
631-
v.Error("rate limiter failed", "error", limiterErr, "method", req.Method, "url", req.URL)
632-
case Logger:
633-
v.Printf("[ERR] %s %s rate limiter failed: %v", req.Method, req.URL, limiterErr)
629+
if limiterErr != nil {
630+
switch v := logger.(type) {
631+
case LeveledLogger:
632+
v.Error("rate limiter failed", "error", limiterErr, "method", req.Method, "url", req.URL)
633+
case Logger:
634+
v.Printf("[ERR] %s %s rate limiter failed: %v", req.Method, req.URL, limiterErr)
635+
}
634636
}
635637

636638
if c.RequestLogHook != nil {

0 commit comments

Comments
 (0)