Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misalignment between node and routed corridor #187

Open
Nate-Wessel opened this issue Jan 23, 2025 · 3 comments
Open

Misalignment between node and routed corridor #187

Nate-Wessel opened this issue Jan 23, 2025 · 3 comments

Comments

@Nate-Wessel
Copy link
Contributor

Nate-Wessel commented Jan 23, 2025

From this comment, it can be seen that a node and a corresponding routed corridor in at least one case do not quite align spatially.

Image

Here is a similar query to the one shown in that comment:
https://trans-bdit.intra.prod-toronto.ca/tt-request-backend/aggregate-travel-times/30414902/30415730/12/17/2025-01-01/2025-01-04/true/1234567

Not a huuuuuge deal, bu I'd like to understand why this is happening. Which underlying dataset is to blame?

@chmnata
Copy link
Contributor

chmnata commented Jan 23, 2025

What layer is it querying from? here.routing_nodes and here.routing_streets?

@Nate-Wessel
Copy link
Contributor Author

Nate-Wessel commented Jan 23, 2025

Here's the relevant code for the node location: https://github.com/CityofToronto/bdit_tt_request_app/blob/deploy/backend/app/nodes/nearby/here.py

Geometry is pulled from congestion.network_nodes which has perhaps become a bit out of sync with the geometries in here.routing_nodes_23_4?

@chmnata
Copy link
Contributor

chmnata commented Jan 23, 2025

Yea totttttttttttally possible, In this map version change (like last year), there were cases where they kept link_dir and node_id the same but the spatial definition changed. My process of updating nodes only drops old ones and insert new node_id, I did not update the geometry of node_id that did not change in between versions. Quick fix would be to pull geometry form routing_nodes_23_4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants