Code quality improvements for the Memory panel

While working on extracting the parsing I noticed small changes
that we can make.

Bug: 454624251
Change-Id: If8434349d63d118bda717327fb1c07ce5e1d6669
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7693137
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>

Author: Lightning00Blade

front_end/panels/profiler/HeapDetachedElementsView.ts

@@ -168,11 +168,16 @@ export class DetachedElementsProfileHeader extends WritableProfileHeader {
   readonly #heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null;
   readonly detachedElements: Protocol.DOM.DetachedElementInfo[]|null;
   constructor(
-      heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null, type: DetachedElementsProfileType,
-      detachedElements: Protocol.DOM.DetachedElementInfo[]|null, title?: string) {
+      heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null,
+      type: DetachedElementsProfileType,
+      detachedElements: Protocol.DOM.DetachedElementInfo[]|null,
+      title?: string,
+  ) {
     super(
-        heapProfilerModel?.debuggerModel() ?? null, type,
-        title || i18nString(UIStrings.detachedElementProfile, {PH1: type.nextProfileUid()}));
+        heapProfilerModel?.debuggerModel() ?? null,
+        type,
+        title || i18nString(UIStrings.detachedElementProfile, {PH1: type.nextProfileUid()}),
+    );
     this.detachedElements = detachedElements;
     this.#heapProfilerModel = heapProfilerModel;
   }

front_end/panels/profiler/HeapProfileView.ts

@@ -457,11 +457,15 @@ export class SamplingHeapProfileHeader extends WritableProfileHeader {
     nodes: never[],
   };
   constructor(
-      heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null, type: SamplingHeapProfileTypeBase,
-      title?: string) {
+      heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null,
+      type: SamplingHeapProfileTypeBase,
+      title?: string,
+  ) {
     super(
-        heapProfilerModel?.debuggerModel() ?? null, type,
-        title || i18nString(UIStrings.profileD, {PH1: type.nextProfileUid()}));
+        heapProfilerModel?.debuggerModel() ?? null,
+        type,
+        title || i18nString(UIStrings.profileD, {PH1: type.nextProfileUid()}),
+    );
     this.heapProfilerModelInternal = heapProfilerModel;
     this.protocolProfileInternal = {
       head: {

front_end/panels/profiler/HeapSnapshotView.ts

@@ -964,8 +964,6 @@ export class HeapSnapshotView extends UI.View.SimpleView implements DataDisplayD
     }
     let objectPopoverHelper: ObjectUI.ObjectPopoverHelper.ObjectPopoverHelper|null;
     return {
-      // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
-      // @ts-expect-error
       box: span.boxInWindow(),
       show: async (popover: UI.GlassPane.GlassPane) => {
         if (!heapProfilerModel) {
@@ -1364,7 +1362,7 @@ export class HeapSnapshotProfileType extends
       return;
     }
 
-    let profile: HeapProfileHeader = new HeapProfileHeader(heapProfilerModel, this);
+    let profile = new HeapProfileHeader(heapProfilerModel, this);
     this.setProfileBeingRecorded(profile);
     this.addProfile(profile);
     profile.updateStatus(i18nString(UIStrings.snapshotting));
@@ -1649,33 +1647,29 @@ export interface TrackingHeapSnapshotProfileTypeEventTypes {
 
 export class HeapProfileHeader extends ProfileHeader {
   readonly heapProfilerModelInternal: SDK.HeapProfilerModel.HeapProfilerModel|null;
-  maxJSObjectId: number;
-  workerProxy: HeapSnapshotWorkerProxy|null;
-  receiver: Common.StringOutputStream.OutputStream|null;
-  snapshotProxy: HeapSnapshotProxy|null;
+  maxJSObjectId = -1;
+  workerProxy: HeapSnapshotWorkerProxy|null = null;
+  receiver: Common.StringOutputStream.OutputStream|null = null;
+  snapshotProxy: HeapSnapshotProxy|null = null;
   readonly loadPromise: Promise<HeapSnapshotProxy>;
   fulfillLoad: (value: HeapSnapshotProxy|PromiseLike<HeapSnapshotProxy>) => void;
-  totalNumberOfChunks: number;
-  bufferedWriter: Bindings.TempFile.TempFile|null;
-  onTempFileReady: (() => void)|null;
+  totalNumberOfChunks = 0;
+  bufferedWriter: Bindings.TempFile.TempFile|null = null;
+  onTempFileReady: (() => void)|null = null;
   failedToCreateTempFile?: boolean;
   wasDisposed?: boolean;
   fileName?: Platform.DevToolsPath.RawPathString;
 
   constructor(
-      heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null, type: HeapSnapshotProfileType, title?: string) {
+      heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null,
+      type: HeapSnapshotProfileType,
+      title?: string,
+  ) {
     super(type, title || i18nString(UIStrings.snapshotD, {PH1: type.nextProfileUid()}));
     this.heapProfilerModelInternal = heapProfilerModel;
-    this.maxJSObjectId = -1;
-    this.workerProxy = null;
-    this.receiver = null;
-    this.snapshotProxy = null;
     const {promise, resolve} = Promise.withResolvers<HeapSnapshotProxy>();
     this.loadPromise = promise;
     this.fulfillLoad = resolve;
-    this.totalNumberOfChunks = 0;
-    this.bufferedWriter = null;
-    this.onTempFileReady = null;
   }
 
   heapProfilerModel(): SDK.HeapProfilerModel.HeapProfilerModel|null {

front_end/panels/profiler/ProfileHeader.ts

@@ -11,17 +11,14 @@ export class ProfileHeader extends Common.ObjectWrapper.ObjectWrapper<EventTypes
   readonly #profileType: ProfileType;
   title: string;
   uid: number;
-  #fromFile: boolean;
-  tempFile: Bindings.TempFile.TempFile|null;
+  #fromFile = false;
+  tempFile: Bindings.TempFile.TempFile|null = null;
 
   constructor(profileType: ProfileType, title: string) {
     super();
     this.#profileType = profileType;
     this.title = title;
     this.uid = profileType.incrementProfileUid();
-    this.#fromFile = false;
-
-    this.tempFile = null;
   }
 
   setTitle(title: string): void {
@@ -103,17 +100,14 @@ export interface EventTypes {
 export class ProfileType extends Common.ObjectWrapper.ObjectWrapper<ProfileEventTypes> {
   readonly #id: string;
   readonly #name: string;
-  profiles: ProfileHeader[];
-  #profileBeingRecorded: ProfileHeader|null;
-  #nextProfileUid: number;
+  profiles: ProfileHeader[] = [];
+  #profileBeingRecorded: ProfileHeader|null = null;
+  #nextProfileUid = 1;
 
   constructor(id: string, name: string) {
     super();
     this.#id = id;
     this.#name = name;
-    this.profiles = [];
-    this.#profileBeingRecorded = null;
-    this.#nextProfileUid = 1;
 
     if (!window.opener) {
       window.addEventListener('pagehide', this.clearTempStorage.bind(this), false);

front_end/ui/legacy/UIUtils.ts

@@ -1691,19 +1691,21 @@ export function createSVGChild<K extends keyof SVGElementTagNameMap>(
   return child;
 }
 
-export const enclosingNodeOrSelfWithNodeNameInArray = (initialNode: Node, nameArray: string[]): Node|null => {
-  let node: (Node|null)|Node = initialNode;
-  for (; node && node !== initialNode.ownerDocument; node = node.parentNodeOrShadowHost()) {
-    for (let i = 0; i < nameArray.length; ++i) {
-      if (node.nodeName.toLowerCase() === nameArray[i].toLowerCase()) {
-        return node;
+export const enclosingNodeOrSelfWithNodeNameInArray =
+    <T extends keyof HTMLElementTagNameMap>(initialNode: Node, nameArray: T[]): HTMLElementTagNameMap[T]|null => {
+      let node: (Node|null)|Node = initialNode;
+      for (; node && node !== initialNode.ownerDocument; node = node.parentNodeOrShadowHost()) {
+        for (let i = 0; i < nameArray.length; ++i) {
+          if (node.nodeName.toLowerCase() === nameArray[i].toLowerCase()) {
+            return node as HTMLElementTagNameMap[T];
+          }
+        }
       }
-    }
-  }
-  return null;
-};
+      return null;
+    };
 
-export const enclosingNodeOrSelfWithNodeName = function(node: Node, nodeName: string): Node|null {
+export const enclosingNodeOrSelfWithNodeName = function<T extends keyof HTMLElementTagNameMap>(
+    node: Node, nodeName: T): HTMLElementTagNameMap[T]|null {
   return enclosingNodeOrSelfWithNodeNameInArray(node, [nodeName]);
 };