Use artifact folder when non is provided

After https://crrev.com/c/7665478 there are new files,
Let's just create a folder so we can ignore everything

Bug: none
Change-Id: I0e19e345a75837b1a033dd993e9025fa495c60bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7666458
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>

Author: Lightning00Blade

.gitignore

@@ -62,8 +62,8 @@ test/perf/.generated
 .stylelintcache
 **/tsconfig.tsbuildinfo
 
-# e2e test runner copies dumps into the source tree.
-*.dmp
+# test runner copies dumps into the source tree.
+artifacts/*
 
 # cipd rollup binaries synced from third_party/
 node_modules/@rollup/rollup*/

test/conductor/test_config.ts

@@ -111,9 +111,17 @@ function configureChrome(executablePath: string) {
   }
 }
 
+const getDefaultArtifactDir = () => {
+  const artifactsPath = path.join(SOURCE_ROOT, 'artifacts');
+  if (!fs.existsSync(artifactsPath)) {
+    fs.mkdirSync(artifactsPath);
+  }
+  return artifactsPath;
+};
+
 export const TestConfig: Config = {
   tests: getTestsFromOptions(),
-  artifactsDir: options['artifacts-dir'] || SOURCE_ROOT,
+  artifactsDir: options['artifacts-dir'] || getDefaultArtifactDir(),
   chromeBinary: options['chrome-binary'] ?? defaultChromePath(),
   serverType: ServerType.HOSTED_MODE,
   debug: options['debug'],

test/unit/karma.conf.ts

@@ -61,10 +61,6 @@ const CustomChrome = function(this: any, _baseBrowserDecorator: unknown, args: B
     });
 
     await (async function dumpCommandLineVariationsToFile() {
-      if (!TestConfig.artifactsDir) {
-        return;
-      }
-
       const versionPage = await browser.newPage();
       await versionPage.goto('chrome://version/?show-variations-cmd');
       const commandLineText =
@@ -73,7 +69,10 @@ const CustomChrome = function(this: any, _baseBrowserDecorator: unknown, args: B
 
       if (commandLineText) {
         fs.writeFileSync(
-            path.join(TestConfig.artifactsDir, 'variations-cmd.txt'), commandLineText, {encoding: 'utf-8'});
+            path.join(TestConfig.artifactsDir, 'variations-cmd.txt'),
+            commandLineText,
+            {encoding: 'utf-8'},
+        );
       }
     })();