Skip to content

Commit 2d647ee

Browse files
szuendDevtools-frontend LUCI CQ
authored andcommitted
[testing] Partially revert logging in unit tests
Now that we found the mystery CI unit test failure, we no longer need the detailed logs. This CL reverts parts of https://crrev.com/c/7664899. We don't need the "PASS:" line for every test, but we keep the `--v=1` chrome log since it's not expensive and somewhat useful. R=kimanh@chromium.org Bug: None Change-Id: I4025c73d18605e73d79e7fb98bab9522ed78e9bc Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7672597 Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org>
1 parent 78995fd commit 2d647ee

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

test/conductor/karma-resultsdb-reporter.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,6 @@ export const ResultsDBReporter = function(
126126
}
127127
} else if (skipped) {
128128
this.write(`==== ${status}: ${testId}\n\n`);
129-
} else {
130-
// TODO(szuend): Only here temporarily to investigate random karma disconnects.
131-
// We'll remove this `else` branch again once we figure out what is
132-
// going on.
133-
this.write(`==== ${status}: ${testId}\n\n`);
134129
}
135130

136131
const testResult: ResultsDb.TestResult = {testId, duration, status, expected, summaryHtml};

test/unit/karma.conf.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ const CustomChrome = function(this: any, _baseBrowserDecorator: unknown, args: B
151151
'--enable-crash-reporter-for-testing', // Works only on linux
152152
`--crash-dumps-dir=${TestConfig.artifactsDir}`,
153153
'--enable-logging',
154-
'--v=2',
154+
'--v=1',
155155
`--log-file=${path.join(TestConfig.artifactsDir, 'chrome-log.txt')}`,
156156
...flagsDisabledWithDebugging,
157157
...args.flags,

0 commit comments

Comments
 (0)